Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Simplify list of known SpanStatus #383

Open
rhcarvalho opened this issue Jul 22, 2021 · 2 comments
Open

Simplify list of known SpanStatus #383

rhcarvalho opened this issue Jul 22, 2021 · 2 comments

Comments

@rhcarvalho
Copy link
Contributor

We currently have a long list of span statuses. Those were inherited from an old, pre-1.0, version of the OpenTelemetry specification.

OpenTelemetry moved on to drastically simplify SpanStatus following OTEP 136.

[...] an existing set of error types without first clearly defining their use and how they might be set has caused confusion.

The extensive list of statuses, without a clear mapping and dubious use across platforms we support (browser, desktop, mobile, web servers, etc), has caused confusion in Sentry too, both for SDK maintainers and end users. For example:

This issue tracks re-aligning with OpenTelemetry, what means today replacing the existing statuses with:

  • Unset (default)
  • Ok
  • Error

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#set-status for details.

@rhcarvalho
Copy link
Contributor Author

@bruno-garcia
Copy link
Member

I replied with all possible emojis:

image

The HTTP-based status seem odd. And have not been documented in terms of what's expected in different cases so SDKs behave very differently regarding what status is used and when.

Unset (default): Great. Often integrations have no opinion about the "outcome" of the span other than name and timing. UI can be less opinionated about "success or failure".

Ok and Error are pretty obvious and work for Mobile, Browser, Desktop, Web Server, background jobs, CLI tools, games, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants