Bump: Sentry JavaScript 7.114.0 #342
Conversation
|
very important and good update, waiting! |
| @@ -22,7 +24,6 @@ | |||
| "devDependencies": { | |||
| "cordova-android": "^12.0.1", | |||
| "cordova-browser": "^7.0.0", | |||
| "cordova-ios": "^7.0.1", | |||
There was a problem hiding this comment.
I don't follow cordova as much, why was the iOS removed?
| } | ||
| }, | ||
| "dependencies": { | ||
| "cordova": "^12.0.0", | ||
| "typescript": "^5.2.2" | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing new line at the end.
| <style> | ||
| body { | ||
| font-family: Arial, sans-serif; | ||
| background-color: #fff; | ||
| padding: 20px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-height: 100vh; | ||
| } | ||
| .titleHeader { | ||
| background-color: #fff; | ||
| } | ||
|
|
||
| .loading-overlay { | ||
| background-color: rgba(0, 0, 0, 0.5); /* semi-transparent black */ | ||
| z-index: 9999; /* ensure it's on top of other elements */ | ||
| display: none; /* initially hidden */ | ||
| } | ||
|
|
||
| h1 { | ||
| color: #333; | ||
| margin-bottom: 20px; | ||
| display: flex; | ||
| align-items: center; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| h1 img { | ||
| width: 30%; | ||
| margin-right: 10px; | ||
| } | ||
|
|
||
| #content { | ||
| flex: 1; | ||
| border: none; | ||
| width: 100%; | ||
| height: calc(100% - 60px); /* Adjust for tab height and margins */ | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Can this also be a css file or is this the default how cordova template is generated?
| function addTag() { | ||
| Sentry.instance.configureScope(scope => scope.u); | ||
|
|
||
| } |
There was a problem hiding this comment.
This function doesn't seem correct. It does not add a tag.
| }} | ||
|
|
||
|
|
| import * as Integrations from './integrations'; | ||
| export { Integrations }; | ||
| export { BrowserIntegrations }; |
There was a problem hiding this comment.
In Browser JS all integration are exported now as functions directly. Sentry.integrationA()
Let's add it here too, since replay, tracing and profiling is exported like this already.
|
Thank you it looks good, but before approving I think we should export all of the integration functions. |
|
@lucas-zimerman Could you add a screenshot of the sample app? |
|
I believe the sample code should be removed from this PR as it's also present in #341 (comment) |
Co-authored-by: Krystof Woldrich <[email protected]>
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This PR will bump Sentry wizard along with Sentry Javascript.
Since there are some big changes on the SDK, I have exposed a new way of using the new integrations (tracing , profiling and replay) on Sentry Cordova. by default they are not added, but there will be documentation on Docs and also on the changelog