-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sentry-cocoa/ fix issue 311 #316
Conversation
… fix wizard breaking ios build
@brustolin could you check this PR? it got a major bump from the cocoa dependency but I think I got all most of the cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a couple of suggestions.
UPDATE: there are still some fixes that will need to be done on Sentry Wizard in order for this PR to fully work |
@lucas-zimerman Is there a Wizard PR/Issue that we could link here? |
getsentry/sentry-wizard#481 |
Instructions and example for changelogPlease add an entry to ## Unreleased
### Fixes/Features
- Bump sentry-cocoa/ fix issue 311 ([#316](https://github.com/getsentry/sentry-cordova/pull/316)) If none of the above apply, you can opt out of this check by adding |
This is a possible fix to the issue #311, previously the SDK wasn't being even build due to having an old sentry-cocoa SDK with unsupported minimum version of iOS...
Changes on the SDK
TODO: