Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sentry-cocoa/ fix issue 311 #316

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Bump sentry-cocoa/ fix issue 311 #316

merged 9 commits into from
Oct 24, 2023

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Aug 24, 2023

This is a possible fix to the issue #311, previously the SDK wasn't being even build due to having an old sentry-cocoa SDK with unsupported minimum version of iOS...

Changes on the SDK

  • Fix Wizard breaking iOS build (fix(cordova) iOS fails to build when sentry.cli not defined sentry-wizard#401)
  • iOS build failing on the latest xCode because minimum MacOS deployiment has increased, requiring a bump on the Sentry Cocoa SDK.
  • Sentry Cocoa SDK bumped from 7.27.1 to 8.9.3
  • Add support for Sentry Private SDK.
  • fix Carthage scripts with the new SDK and remove unused Swift code.

TODO:

  • Update Changelog.
  • Add break changes from the bump of Sentry Cocoa.
  • Validate on an iOS app.
  • Build Pass on Github

@lucas-zimerman lucas-zimerman changed the title Bump sentry-cocoa/ fix for issue Bump sentry-cocoa/ fix issue 331 Aug 24, 2023
@lucas-zimerman lucas-zimerman marked this pull request as ready for review September 4, 2023 16:32
@lucas-zimerman
Copy link
Collaborator Author

@brustolin could you check this PR? it got a major bump from the cocoa dependency but I think I got all most of the cases

Copy link

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a couple of suggestions.

src/ios/Cartfile Outdated Show resolved Hide resolved
src/ios/SentryCordova.m Outdated Show resolved Hide resolved
@lucas-zimerman
Copy link
Collaborator Author

UPDATE: there are still some fixes that will need to be done on Sentry Wizard in order for this PR to fully work

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Sep 25, 2023

@lucas-zimerman Is there a Wizard PR/Issue that we could link here?

@kahest kahest changed the title Bump sentry-cocoa/ fix issue 331 Bump sentry-cocoa/ fix issue 311 Oct 3, 2023
@lucas-zimerman
Copy link
Collaborator Author

getsentry/sentry-wizard#481
PR here merged, I'll bump this branch and merge it

@lucas-zimerman lucas-zimerman merged commit 6d3ad48 into main Oct 24, 2023
11 checks passed
@lucas-zimerman lucas-zimerman deleted the fix/311 branch October 24, 2023 13:25
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:

## Unreleased

### Fixes/Features

- Bump sentry-cocoa/ fix issue 311 ([#316](https://github.com/getsentry/sentry-cordova/pull/316))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against dbae360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants