Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add variable escaping in Makefile #4669

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

philprime
Copy link
Contributor

📜 Description

Fixes the variable escaping of awk in the Makefile

💡 Motivation and Context

Running make init

💚 How did you test it?

  1. Run make init without the changes
  2. File .clang-format-version contains clang-format version 19.1.6
  3. Applying changes of PR
  4. Run make init again
  5. File .clang-format-version contains 19.1.6

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

@philprime philprime changed the title fix: add variable escaping in Makefile fix: Add variable escaping in Makefile Jan 2, 2025
@philprime philprime self-assigned this Jan 2, 2025
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit de53666 into main Jan 2, 2025
8 checks passed
@philprime philprime deleted the philprime/fix-makefile branch January 2, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants