fix: Session Redact wrong clipping order

[brustolin]

📜 Description

Fix an error where SR clipping happens in the wrong order.

💡 Motivation and Context

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• I updated the wizard if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.598%. Comparing base (950adcc) to head (d4db9aa).
Report is 3 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4651       +/-   ##
=============================================
- Coverage   90.612%   90.598%   -0.014%     
=============================================
  Files          621       621               
  Lines        71103     71119       +16     
  Branches     25927     25308      -619     
=============================================
+ Hits         64428     64433        +5     
- Misses        6579      6593       +14     
+ Partials        96        93        -3     

Files with missing lines	Coverage Δ
Sources/Swift/Tools/SentryViewPhotographer.swift	88.888% <100.000%> (-0.203%)	⬇️
Sources/Swift/Tools/UIRedactBuilder.swift	91.111% <100.000%> (ø)
...ests/SentryTests/SentryViewPhotographerTests.swift	99.665% <100.000%> (+0.030%)	⬆️

... and 25 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950adcc...d4db9aa. Read the comment docs.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1208.13 ms	1237.60 ms	29.47 ms
Size	22.32 KiB	761.25 KiB	738.93 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
99fe600	1226.16 ms	1236.88 ms	10.71 ms
2af280d	1232.31 ms	1249.98 ms	17.67 ms
3cdbaf1	1221.98 ms	1241.77 ms	19.79 ms
277f226	1241.65 ms	1253.74 ms	12.09 ms
1223af7	1212.84 ms	1227.49 ms	14.65 ms
84640bd	1218.29 ms	1240.00 ms	21.71 ms
bd2cb64	1216.14 ms	1241.78 ms	25.64 ms
9454d5d	1230.55 ms	1243.42 ms	12.87 ms
32e64d1	1249.42 ms	1264.76 ms	15.34 ms
371db89	1226.40 ms	1251.54 ms	25.14 ms

App size

Revision	Plain	With Sentry	Diff
99fe600	21.90 KiB	708.13 KiB	686.23 KiB
2af280d	20.76 KiB	435.22 KiB	414.46 KiB
3cdbaf1	22.31 KiB	756.53 KiB	734.22 KiB
277f226	22.84 KiB	401.67 KiB	378.83 KiB
1223af7	21.90 KiB	726.19 KiB	704.29 KiB
84640bd	21.90 KiB	727.72 KiB	705.82 KiB
bd2cb64	22.85 KiB	413.45 KiB	390.60 KiB
9454d5d	20.76 KiB	436.29 KiB	415.53 KiB
32e64d1	20.76 KiB	433.18 KiB	412.42 KiB
371db89	20.76 KiB	427.31 KiB	406.55 KiB

[armcknight]

Is there an issue tracking this? Could we see a before/after shot from actual results in the dashboard?

[brustolin]

Is there an issue tracking this?

There is no issue for this, we were investigating a crash and we found the crash was caused by wrongly skipping some clips

[philprime]

LGTM