Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix certificate for iOS-Swift sample #4521

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

brustolin
Copy link
Contributor

Fixing the certificate for the sample that we use for benchmark and TestFlight.

#skip-changelog

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

github-actions bot commented Nov 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.88 ms 1232.08 ms 23.21 ms
Size 21.90 KiB 730.10 KiB 708.20 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6bc5ae5 1230.90 ms 1246.10 ms 15.20 ms
3d8532d 1225.27 ms 1238.80 ms 13.53 ms
fa1ec44 1216.80 ms 1244.42 ms 27.62 ms
5616e0a 1237.00 ms 1260.43 ms 23.43 ms
ed49f0c 1215.94 ms 1245.63 ms 29.69 ms
af1f4dd 1238.08 ms 1258.48 ms 20.40 ms
50bb751 1207.51 ms 1219.37 ms 11.86 ms
c838244 1213.51 ms 1243.76 ms 30.24 ms
39b1c35 1236.35 ms 1239.90 ms 3.55 ms
56ec5d0 1236.65 ms 1261.90 ms 25.25 ms

App size

Revision Plain With Sentry Diff
6bc5ae5 20.76 KiB 401.40 KiB 380.64 KiB
3d8532d 22.85 KiB 414.09 KiB 391.24 KiB
fa1ec44 21.58 KiB 670.39 KiB 648.81 KiB
5616e0a 22.85 KiB 407.45 KiB 384.60 KiB
ed49f0c 21.58 KiB 632.13 KiB 610.55 KiB
af1f4dd 22.85 KiB 414.71 KiB 391.86 KiB
50bb751 21.58 KiB 417.86 KiB 396.27 KiB
c838244 21.58 KiB 629.61 KiB 608.03 KiB
39b1c35 22.85 KiB 408.88 KiB 386.03 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.69 KiB

Previous results on branch: fix/certificate

Startup times

Revision Plain With Sentry Diff
48a7d02 1215.37 ms 1233.47 ms 18.09 ms

App size

Revision Plain With Sentry Diff
48a7d02 21.90 KiB 730.10 KiB 708.20 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@brustolin brustolin merged commit 489fbb8 into main Nov 8, 2024
52 checks passed
@brustolin brustolin deleted the fix/certificate branch November 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants