Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash during SDK initialization due to corrupted envelope #4291

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

brustolin
Copy link
Contributor

This reverts commit 804fd04.

📜 Description

Reverting #4219 to further investigation

💡 Motivation and Context

Close #4280

@brustolin brustolin changed the title fix: Revert #4219 fix: Crash during SDK initialization due to corrupted envelope Aug 19, 2024
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

CHANGELOG.md Show resolved Hide resolved
@brustolin brustolin merged commit a95ba2f into main Aug 19, 2024
59 checks passed
@brustolin brustolin deleted the fix/revert-4219 branch August 19, 2024 14:28
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.714%. Comparing base (8ef07fb) to head (93806cf).
Report is 1 commits behind head on main.

Files Patch % Lines
Sources/Sentry/SentrySerialization.m 77.777% 2 Missing ⚠️
Sources/Sentry/SentryFileManager.m 75.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4291       +/-   ##
=============================================
+ Coverage   91.682%   91.714%   +0.032%     
=============================================
  Files          617       617               
  Lines        50218     50195       -23     
  Branches     18127     18122        -5     
=============================================
- Hits         46041     46036        -5     
+ Misses        4085      4067       -18     
  Partials        92        92               
Files Coverage Δ
...ts/SentryTests/Helper/SentryFileManagerTests.swift 99.299% <100.000%> (-0.004%) ⬇️
...tryTests/Networking/SentryHttpTransportTests.swift 99.702% <100.000%> (-0.001%) ⬇️
Sources/Sentry/SentryFileManager.m 93.281% <75.000%> (+0.531%) ⬆️
Sources/Sentry/SentrySerialization.m 91.826% <77.777%> (+0.199%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef07fb...93806cf. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.61 ms 1238.29 ms 26.67 ms
Size 21.58 KiB 706.46 KiB 684.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fa1ec44 1216.80 ms 1244.42 ms 27.62 ms
596ccc1 1230.85 ms 1244.24 ms 13.39 ms
d253cdf 1231.61 ms 1259.52 ms 27.91 ms
649d940 1227.06 ms 1245.19 ms 18.13 ms
5e78d2b 1229.90 ms 1252.94 ms 23.04 ms
4977fbc 1217.26 ms 1239.82 ms 22.56 ms
94e1968 1234.41 ms 1252.63 ms 18.22 ms
2af280d 1246.22 ms 1253.10 ms 6.88 ms
ebeb68c 1216.27 ms 1243.80 ms 27.53 ms
dd0557f 1251.82 ms 1256.76 ms 4.94 ms

App size

Revision Plain With Sentry Diff
fa1ec44 21.58 KiB 670.39 KiB 648.81 KiB
596ccc1 22.84 KiB 401.44 KiB 378.60 KiB
d253cdf 20.76 KiB 427.66 KiB 406.90 KiB
649d940 21.58 KiB 695.36 KiB 673.78 KiB
5e78d2b 22.85 KiB 411.17 KiB 388.32 KiB
4977fbc 20.76 KiB 419.85 KiB 399.10 KiB
94e1968 21.58 KiB 614.74 KiB 593.15 KiB
2af280d 20.76 KiB 435.22 KiB 414.46 KiB
ebeb68c 21.58 KiB 698.37 KiB 676.79 KiB
dd0557f 22.85 KiB 411.75 KiB 388.91 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash during SDK initialization, presumably due to corrupted envelope data from a previous run
2 participants