Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version bumping #4151

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix: version bumping #4151

merged 2 commits into from
Jul 10, 2024

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Jul 9, 2024

After merging #4140, the release workflow broke because I changed where the version number was stored in config.

I cleaned up how that's done because it was still duplicated across two config files. Now it's in only SDK.xcconfig, and the version bump script now looks there.

#skip-changelog

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.379%. Comparing base (5230990) to head (7ddf10b).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4151       +/-   ##
=============================================
+ Coverage   91.370%   91.379%   +0.008%     
=============================================
  Files          605       605               
  Lines        48267     48267               
  Branches     17407     17415        +8     
=============================================
+ Hits         44102     44106        +4     
+ Misses        4072      4069        -3     
+ Partials        93        92        -1     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5230990...7ddf10b. Read the comment docs.

Copy link

github-actions bot commented Jul 9, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.16 ms 1235.16 ms 13.00 ms
Size 21.58 KiB 682.39 KiB 660.81 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a71f5e2 1245.27 ms 1258.00 ms 12.73 ms
3437454 1225.64 ms 1234.31 ms 8.67 ms
e8b14db 1193.58 ms 1225.56 ms 31.98 ms
da2f43e 1228.27 ms 1251.52 ms 23.25 ms
fa409fe 1229.04 ms 1243.96 ms 14.92 ms
98cca71 1210.75 ms 1240.64 ms 29.89 ms
a9dece3 1224.96 ms 1245.27 ms 20.31 ms
9d56232 1192.09 ms 1228.86 ms 36.77 ms
8e4bc70 1229.18 ms 1240.86 ms 11.67 ms
7bb0873 1360.94 ms 1362.24 ms 1.30 ms

App size

Revision Plain With Sentry Diff
a71f5e2 21.58 KiB 424.34 KiB 402.76 KiB
3437454 22.85 KiB 408.87 KiB 386.02 KiB
e8b14db 20.76 KiB 401.60 KiB 380.84 KiB
da2f43e 21.58 KiB 542.38 KiB 520.80 KiB
fa409fe 21.58 KiB 546.20 KiB 524.62 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
a9dece3 21.58 KiB 546.20 KiB 524.62 KiB
9d56232 20.76 KiB 425.80 KiB 405.04 KiB
8e4bc70 21.58 KiB 625.90 KiB 604.32 KiB
7bb0873 22.85 KiB 407.09 KiB 384.24 KiB

@armcknight armcknight merged commit 2df93b0 into main Jul 10, 2024
66 of 67 checks passed
@armcknight armcknight deleted the armcknight/fix/versioning branch July 10, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants