Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put crash logger default local level back to none #4100

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Jun 21, 2024

I accidentally left a change that I was using to debug in this PR: 1e803dc#diff-242aeee1da34d09c29c968f7c11e8fc2a5cd9abe5e6cd0de3334d28cb06e8744R244

image

This should default to None.

#skip-changelog

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.421%. Comparing base (b9fc537) to head (a20d2d0).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4100       +/-   ##
=============================================
+ Coverage   91.368%   91.421%   +0.052%     
=============================================
  Files          610       610               
  Lines        48372     48366        -6     
  Branches     17488     17350      -138     
=============================================
+ Hits         44197     44217       +20     
+ Misses        4082      4058       -24     
+ Partials        93        91        -2     
Files Coverage Δ
...es/SentryCrash/Recording/Tools/SentryCrashLogger.h 100.000% <ø> (+20.000%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fc537...a20d2d0. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.02 ms 1233.00 ms 18.98 ms
Size 21.58 KiB 671.52 KiB 649.94 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a6f8b18 1236.96 ms 1240.14 ms 3.18 ms
31208ed 1217.45 ms 1246.69 ms 29.24 ms
fcde045 1260.71 ms 1275.00 ms 14.29 ms
f2daa68 1238.40 ms 1256.43 ms 18.03 ms
7a7de19 1251.30 ms 1266.94 ms 15.64 ms
9454d5d 1230.55 ms 1243.42 ms 12.87 ms
2cf1b84 1221.10 ms 1230.34 ms 9.24 ms
3297d6e 1196.90 ms 1213.24 ms 16.35 ms
2affdbd 1224.29 ms 1248.06 ms 23.77 ms
44ce888 1208.98 ms 1224.72 ms 15.74 ms

App size

Revision Plain With Sentry Diff
a6f8b18 20.76 KiB 431.87 KiB 411.11 KiB
31208ed 20.76 KiB 435.26 KiB 414.50 KiB
fcde045 20.76 KiB 435.26 KiB 414.50 KiB
f2daa68 21.58 KiB 418.40 KiB 396.82 KiB
7a7de19 20.76 KiB 435.64 KiB 414.88 KiB
9454d5d 20.76 KiB 436.29 KiB 415.53 KiB
2cf1b84 20.76 KiB 431.91 KiB 411.15 KiB
3297d6e 21.58 KiB 418.44 KiB 396.86 KiB
2affdbd 22.85 KiB 411.37 KiB 388.52 KiB
44ce888 22.85 KiB 414.65 KiB 391.80 KiB

@armcknight armcknight enabled auto-merge (squash) June 24, 2024 17:18
@armcknight armcknight merged commit 8cf5bca into main Jun 24, 2024
64 of 68 checks passed
@armcknight armcknight deleted the armcknight/fix/crash-logger-level branch June 24, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants