-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(profiling): rename more functions to prefix with sentry_
and remove leading underscores on public members
#3874
ref(profiling): rename more functions to prefix with sentry_
and remove leading underscores on public members
#3874
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3874 +/- ##
=============================================
+ Coverage 90.581% 90.626% +0.044%
=============================================
Files 579 580 +1
Lines 45200 45289 +89
Branches 16059 16115 +56
=============================================
+ Hits 40943 41044 +101
- Misses 4076 4175 +99
+ Partials 181 70 -111
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b9a9dca | 1196.09 ms | 1225.14 ms | 29.05 ms |
f8833c4 | 1236.45 ms | 1252.82 ms | 16.37 ms |
8f397a7 | 1230.10 ms | 1253.88 ms | 23.77 ms |
7fb7afb | 1202.18 ms | 1219.42 ms | 17.24 ms |
6c31077 | 1226.24 ms | 1237.24 ms | 11.00 ms |
eaa1002 | 1205.50 ms | 1235.08 ms | 29.58 ms |
bd2afa6 | 1245.24 ms | 1263.18 ms | 17.94 ms |
ff09c7e | 1240.94 ms | 1262.66 ms | 21.72 ms |
f8fc36d | 1226.31 ms | 1247.80 ms | 21.49 ms |
add8416 | 1270.72 ms | 1300.38 ms | 29.66 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b9a9dca | 21.58 KiB | 414.59 KiB | 393.01 KiB |
f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
6c31077 | 22.84 KiB | 401.66 KiB | 378.81 KiB |
eaa1002 | 20.76 KiB | 423.19 KiB | 402.43 KiB |
bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
ff09c7e | 20.76 KiB | 427.76 KiB | 407.00 KiB |
f8fc36d | 20.76 KiB | 419.70 KiB | 398.94 KiB |
add8416 | 21.58 KiB | 541.91 KiB | 520.33 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…continuous-profiling/4-refactoring/3-renames
Following on #3873, for #3555, #skip-changelog
Just renaming these functions to namespace then the same as was done in #3862