Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(profiling): rename more functions to prefix with sentry_ and remove leading underscores on public members #3874

Conversation

armcknight
Copy link
Member

Following on #3873, for #3555, #skip-changelog

Just renaming these functions to namespace then the same as was done in #3862

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.626%. Comparing base (42f4107) to head (e4893c2).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3874       +/-   ##
=============================================
+ Coverage   90.581%   90.626%   +0.044%     
=============================================
  Files          579       580        +1     
  Lines        45200     45289       +89     
  Branches     16059     16115       +56     
=============================================
+ Hits         40943     41044      +101     
- Misses        4076      4175       +99     
+ Partials       181        70      -111     
Files Coverage Δ
SentryTestUtils/ClearTestState.swift 100.000% <100.000%> (ø)
Sources/Sentry/PrivateSentrySDKOnly.mm 87.155% <100.000%> (ø)
...entry/Profiling/SentryProfiledTracerConcurrency.mm 97.368% <100.000%> (ø)
Sources/Sentry/SentryProfiler.mm 89.036% <100.000%> (ø)
Sources/Sentry/SentryTracer.m 96.897% <100.000%> (+0.238%) ⬆️
...SentryProfilerTests/SentryProfilerSwiftTests.swift 98.646% <100.000%> (ø)
Tests/SentryProfilerTests/SentryProfilerTests.mm 98.773% <100.000%> (ø)

... and 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f4107...e4893c2. Read the comment docs.

Copy link

github-actions bot commented Apr 23, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.92 ms 1253.82 ms 17.90 ms
Size 21.58 KiB 614.92 KiB 593.34 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b9a9dca 1196.09 ms 1225.14 ms 29.05 ms
f8833c4 1236.45 ms 1252.82 ms 16.37 ms
8f397a7 1230.10 ms 1253.88 ms 23.77 ms
7fb7afb 1202.18 ms 1219.42 ms 17.24 ms
6c31077 1226.24 ms 1237.24 ms 11.00 ms
eaa1002 1205.50 ms 1235.08 ms 29.58 ms
bd2afa6 1245.24 ms 1263.18 ms 17.94 ms
ff09c7e 1240.94 ms 1262.66 ms 21.72 ms
f8fc36d 1226.31 ms 1247.80 ms 21.49 ms
add8416 1270.72 ms 1300.38 ms 29.66 ms

App size

Revision Plain With Sentry Diff
b9a9dca 21.58 KiB 414.59 KiB 393.01 KiB
f8833c4 21.58 KiB 422.66 KiB 401.08 KiB
8f397a7 20.76 KiB 420.55 KiB 399.79 KiB
7fb7afb 20.76 KiB 419.70 KiB 398.94 KiB
6c31077 22.84 KiB 401.66 KiB 378.81 KiB
eaa1002 20.76 KiB 423.19 KiB 402.43 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
ff09c7e 20.76 KiB 427.76 KiB 407.00 KiB
f8fc36d 20.76 KiB 419.70 KiB 398.94 KiB
add8416 21.58 KiB 541.91 KiB 520.33 KiB

Previous results on branch: armcknight/feat/3555-continuous-profiling/4-refactoring/3-renames

Startup times

Revision Plain With Sentry Diff
ea8eb7b 1229.61 ms 1244.12 ms 14.51 ms

App size

Revision Plain With Sentry Diff
ea8eb7b 21.58 KiB 615.00 KiB 593.42 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from armcknight/feat/3555-continuous-profiling/4-refactoring/2-test-helpers to main April 23, 2024 18:15
…continuous-profiling/4-refactoring/3-renames
@armcknight armcknight merged commit a7ca2d1 into main Apr 23, 2024
70 checks passed
@armcknight armcknight deleted the armcknight/feat/3555-continuous-profiling/4-refactoring/3-renames branch April 23, 2024 19:24
dKasabwala pushed a commit to dKasabwala/sentry-cocoa that referenced this pull request May 6, 2024
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants