Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Rename "http.method" to "http.request.method" for network Spans #3268

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Sep 5, 2023

📜 Description

Renamed "http.method" to "http.request.method" for network Spans

💡 Motivation and Context

close #3234

💚 How did you test it?

Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.94 ms 1235.52 ms 25.58 ms
Size 22.85 KiB 407.39 KiB 384.54 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3ea21f5 1250.80 ms 1258.88 ms 8.08 ms
ecd9ecd 1191.76 ms 1216.92 ms 25.16 ms
dbc67d2 1239.49 ms 1248.88 ms 9.39 ms
b6ba04e 1217.45 ms 1248.92 ms 31.47 ms
189b629 1211.16 ms 1224.30 ms 13.14 ms
25a5e8b 1249.18 ms 1268.42 ms 19.24 ms
9d61bea 1243.88 ms 1254.36 ms 10.48 ms
31208ed 1258.36 ms 1263.86 ms 5.50 ms
66922ca 1221.68 ms 1235.98 ms 14.30 ms
5b6694b 1221.71 ms 1259.06 ms 37.35 ms

App size

Revision Plain With Sentry Diff
3ea21f5 22.84 KiB 402.63 KiB 379.78 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
dbc67d2 20.76 KiB 427.74 KiB 406.98 KiB
b6ba04e 20.76 KiB 414.45 KiB 393.69 KiB
189b629 20.76 KiB 399.69 KiB 378.93 KiB
25a5e8b 20.76 KiB 436.33 KiB 415.57 KiB
9d61bea 20.76 KiB 436.29 KiB 415.53 KiB
31208ed 20.76 KiB 435.26 KiB 414.50 KiB
66922ca 20.76 KiB 425.80 KiB 405.04 KiB
5b6694b 20.76 KiB 426.11 KiB 405.34 KiB

Previous results on branch: feat/remame-http-method

Startup times

Revision Plain With Sentry Diff
f49a024 1219.63 ms 1234.43 ms 14.80 ms
0c12e52 1212.73 ms 1238.78 ms 26.05 ms

App size

Revision Plain With Sentry Diff
f49a024 22.85 KiB 407.39 KiB 384.54 KiB
0c12e52 22.85 KiB 407.39 KiB 384.54 KiB

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #3268 (04fca13) into main (9fa25c2) will decrease coverage by 0.055%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3268       +/-   ##
=============================================
- Coverage   89.258%   89.204%   -0.055%     
=============================================
  Files          502       502               
  Lines        54257     54262        +5     
  Branches     19484     19483        -1     
=============================================
- Hits         48429     48404       -25     
- Misses        4973      4994       +21     
- Partials       855       864        +9     
Files Changed Coverage
Sources/Sentry/SentryNetworkTracker.m 100.000%
...erformance/Network/SentryNetworkTrackerTests.swift 100.000%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa25c2...04fca13. Read the comment docs.

@brustolin brustolin merged commit d61b939 into main Sep 6, 2023
65 of 66 checks passed
@brustolin brustolin deleted the feat/remame-http-method branch September 6, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Starfish] Add starfish v1 http attributes to span data
3 participants