-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Rename "http.method" to "http.request.method" for network Spans #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brustolin
requested review from
philipphofmann and
armcknight
as code owners
September 5, 2023 14:51
…-cocoa into feat/remame-http-method
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3ea21f5 | 1250.80 ms | 1258.88 ms | 8.08 ms |
ecd9ecd | 1191.76 ms | 1216.92 ms | 25.16 ms |
dbc67d2 | 1239.49 ms | 1248.88 ms | 9.39 ms |
b6ba04e | 1217.45 ms | 1248.92 ms | 31.47 ms |
189b629 | 1211.16 ms | 1224.30 ms | 13.14 ms |
25a5e8b | 1249.18 ms | 1268.42 ms | 19.24 ms |
9d61bea | 1243.88 ms | 1254.36 ms | 10.48 ms |
31208ed | 1258.36 ms | 1263.86 ms | 5.50 ms |
66922ca | 1221.68 ms | 1235.98 ms | 14.30 ms |
5b6694b | 1221.71 ms | 1259.06 ms | 37.35 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3ea21f5 | 22.84 KiB | 402.63 KiB | 379.78 KiB |
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
dbc67d2 | 20.76 KiB | 427.74 KiB | 406.98 KiB |
b6ba04e | 20.76 KiB | 414.45 KiB | 393.69 KiB |
189b629 | 20.76 KiB | 399.69 KiB | 378.93 KiB |
25a5e8b | 20.76 KiB | 436.33 KiB | 415.57 KiB |
9d61bea | 20.76 KiB | 436.29 KiB | 415.53 KiB |
31208ed | 20.76 KiB | 435.26 KiB | 414.50 KiB |
66922ca | 20.76 KiB | 425.80 KiB | 405.04 KiB |
5b6694b | 20.76 KiB | 426.11 KiB | 405.34 KiB |
Codecov Report
@@ Coverage Diff @@
## main #3268 +/- ##
=============================================
- Coverage 89.258% 89.204% -0.055%
=============================================
Files 502 502
Lines 54257 54262 +5
Branches 19484 19483 -1
=============================================
- Hits 48429 48404 -25
- Misses 4973 4994 +21
- Partials 855 864 +9
Continue to review full report in Codecov by Sentry.
|
armcknight
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Renamed "http.method" to "http.request.method" for network Spans
💡 Motivation and Context
close #3234
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps