-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: rename SentryTimerWrapper to SentryTimerFactory #3120
ref: rename SentryTimerWrapper to SentryTimerFactory #3120
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e342ac | 1220.24 ms | 1240.14 ms | 19.90 ms |
49819af | 1263.92 ms | 1275.66 ms | 11.74 ms |
46f5eb8 | 1212.27 ms | 1231.42 ms | 19.15 ms |
c319795 | 1205.12 ms | 1231.20 ms | 26.08 ms |
f587451 | 1271.63 ms | 1275.90 ms | 4.27 ms |
fcde045 | 1260.71 ms | 1275.00 ms | 14.29 ms |
d3edf46 | 1213.00 ms | 1227.46 ms | 14.46 ms |
e84bc3f | 1196.62 ms | 1218.86 ms | 22.24 ms |
1db04d8 | 1250.20 ms | 1258.12 ms | 7.92 ms |
8e76be4 | 1272.67 ms | 1286.38 ms | 13.71 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e342ac | 20.76 KiB | 436.66 KiB | 415.90 KiB |
49819af | 20.76 KiB | 427.31 KiB | 406.55 KiB |
46f5eb8 | 20.76 KiB | 432.37 KiB | 411.61 KiB |
c319795 | 20.76 KiB | 431.99 KiB | 411.22 KiB |
f587451 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
fcde045 | 20.76 KiB | 435.26 KiB | 414.50 KiB |
d3edf46 | 20.76 KiB | 436.65 KiB | 415.89 KiB |
e84bc3f | 20.76 KiB | 434.72 KiB | 413.96 KiB |
1db04d8 | 20.76 KiB | 435.50 KiB | 414.74 KiB |
8e76be4 | 20.76 KiB | 427.66 KiB | 406.89 KiB |
Previous results on branch: armcknight/ref/rename-sentry-nstimer-wrapper-to-factory
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
928cca5 | 1231.31 ms | 1247.20 ms | 15.89 ms |
9999991 | 1241.84 ms | 1264.20 ms | 22.36 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
928cca5 | 20.76 KiB | 401.56 KiB | 380.80 KiB |
9999991 | 20.76 KiB | 401.53 KiB | 380.77 KiB |
#import "SentryNSTimerWrapper.h" | ||
|
||
@interface | ||
SentryNSTimerWrapper () | ||
|
||
@end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file never had any declarations, just leftover.
since it's no longer a subclass after the recent fixes, it's now a factory
a7ec7f2
to
cca9220
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3120 +/- ##
=============================================
+ Coverage 89.007% 89.015% +0.008%
=============================================
Files 500 500
Lines 53926 53902 -24
Branches 19296 19287 -9
=============================================
- Hits 47998 47981 -17
- Misses 4962 5064 +102
+ Partials 966 857 -109
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…-sentry-nstimer-wrapper-to-factory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
since it's no longer a subclass after the recent fixes, it's now a factory. Noticed as I made the change in #3119
#skip-changelog