Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: retry codecov steps one time if they fail #3010

Merged
merged 1 commit into from
May 8, 2023

Conversation

armcknight
Copy link
Member

I've seen many codecov step failures, often due to network request failures (see latest example). Perform one retry just in case. Because there's no script invocation, we can't use the same kind of retry strategy as elsewhere where we use a bash for loop, and we can't use the retry-step action from the GitHub Action marketplace, so I used the duplicate action strategy mentioned here: https://www.thisdot.co/blog/how-to-retry-failed-steps-in-github-action-workflows

#skip-changelog

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #3010 (d6fdfc9) into main (034be1c) will increase coverage by 0.241%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3010       +/-   ##
=============================================
+ Coverage   88.307%   88.548%   +0.241%     
=============================================
  Files          495       495               
  Lines        53230     56693     +3463     
  Branches     19114     19205       +91     
=============================================
+ Hits         47006     50201     +3195     
- Misses        5256      5643      +387     
+ Partials       968       849      -119     

see 245 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034be1c...d6fdfc9. Read the comment docs.

fail_ci_if_error: false
verbose: true

# Sometimes codecov uploads etc can fail. Retry one time to rule out e.g. intermittent network failures.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for the comment on why we need this.

@armcknight armcknight merged commit d3edf46 into main May 8, 2023
@armcknight armcknight deleted the armcknight/ci/retry-codecov branch May 8, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants