Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove some dead code #2864

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

armcknight
Copy link
Member

I was looking at a couple places where we use a dynamic key to insert values into dictionaries as possible candidates for an exception to be thrown, and found a couple macros that expand to such code, but don't appear to be used in the codebase.

#skip-changelog

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1199.60 ms 1218.36 ms 18.76 ms
Size 20.76 KiB 431.91 KiB 411.15 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d253cdf 1231.61 ms 1259.52 ms 27.91 ms
cbf6225 1221.73 ms 1251.20 ms 29.47 ms
7fb7afb 1235.00 ms 1256.81 ms 21.81 ms
20163bb 1248.92 ms 1258.48 ms 9.56 ms
78d5983 1229.98 ms 1245.60 ms 15.62 ms
1bbcb9c 1214.25 ms 1230.04 ms 15.79 ms
8f397a7 1251.82 ms 1268.34 ms 16.52 ms
725565a 1234.59 ms 1250.02 ms 15.43 ms
cce35c6 1228.88 ms 1241.14 ms 12.26 ms
a9103fe 1265.47 ms 1267.37 ms 1.90 ms

App size

Revision Plain With Sentry Diff
d253cdf 20.76 KiB 427.66 KiB 406.90 KiB
cbf6225 20.76 KiB 425.77 KiB 405.00 KiB
7fb7afb 20.76 KiB 419.69 KiB 398.94 KiB
20163bb 20.76 KiB 426.82 KiB 406.06 KiB
78d5983 20.76 KiB 427.80 KiB 407.04 KiB
1bbcb9c 20.76 KiB 426.10 KiB 405.34 KiB
8f397a7 20.76 KiB 420.55 KiB 399.79 KiB
725565a 20.76 KiB 426.11 KiB 405.35 KiB
cce35c6 20.76 KiB 425.80 KiB 405.04 KiB
a9103fe 20.76 KiB 426.95 KiB 406.19 KiB

Previous results on branch: armcknight/ref/remove-dead-code

Startup times

Revision Plain With Sentry Diff
e0da0d6 1218.63 ms 1230.12 ms 11.49 ms

App size

Revision Plain With Sentry Diff
e0da0d6 20.76 KiB 431.91 KiB 411.15 KiB

@armcknight
Copy link
Member Author

tests should pass after merging #2867

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's always great to see dead code deleted 😀.

@armcknight armcknight merged commit e681215 into main Apr 7, 2023
@armcknight armcknight deleted the armcknight/ref/remove-dead-code branch April 7, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants