-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add EXC_BAD_ACCESS subtypes to events #2667
Conversation
Add EXC_BAD_ACCESS subtypes to unhandled errors on arm CPUs. Previously the CrashDoctor always diagnosed a memory crash as Attempted to dereference garbage pointer at 0x13fd4582e. Now the SDK replaces the generic message with the specific subtype.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Tests need fixing and we're good to go.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
==========================================
- Coverage 80.61% 80.57% -0.05%
==========================================
Files 247 247
Lines 22856 22869 +13
Branches 10120 10125 +5
==========================================
+ Hits 18426 18427 +1
- Misses 3972 3981 +9
- Partials 458 461 +3
Continue to review full report at Codecov.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b2f82fa | 1237.78 ms | 1256.02 ms | 18.24 ms |
ddc9b9a | 1201.71 ms | 1226.70 ms | 24.99 ms |
dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
4977fbc | 1231.55 ms | 1239.80 ms | 8.25 ms |
156e771 | 1228.06 ms | 1242.64 ms | 14.58 ms |
9faf217 | 1268.86 ms | 1274.82 ms | 5.96 ms |
15b8c61 | 1223.16 ms | 1244.83 ms | 21.67 ms |
83d2d84 | 1211.31 ms | 1227.34 ms | 16.03 ms |
1bd0055 | 1207.57 ms | 1223.10 ms | 15.53 ms |
443723a | 1205.24 ms | 1220.52 ms | 15.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
ddc9b9a | 20.76 KiB | 420.40 KiB | 399.65 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
4977fbc | 20.76 KiB | 419.86 KiB | 399.10 KiB |
156e771 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
9faf217 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
15b8c61 | 20.76 KiB | 419.67 KiB | 398.91 KiB |
83d2d84 | 20.76 KiB | 419.66 KiB | 398.90 KiB |
1bd0055 | 20.76 KiB | 420.22 KiB | 399.46 KiB |
443723a | 20.76 KiB | 414.44 KiB | 393.68 KiB |
📜 Description
Add EXC_BAD_ACCESS subtypes to unhandled errors on arm CPUs. Previously the CrashDoctor always diagnosed a memory crash as
Attempted to dereference garbage pointer at 0x13fd4582e
. Now the SDK replaces the generic message with the specific subtype.This change has no impact on grouping.
💡 Motivation and Context
Came up while investigating #2662. This is also related to #2665.
💚 How did you test it?
Generating a crash report with a subtype
EXC_ARM_DA_ALIGN
and unit tests.📝 Checklist
sendDefaultPII
is enabled🔮 Next steps