Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trending movies build #2480

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Dec 1, 2022

#2408 changed API that broke TrendingMovies but was not caught in CI due to invalid caching strategy (fixed in #2479 )

#skip-changelog

@armcknight armcknight changed the base branch from master to 8.0.0 December 1, 2022 19:29
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #2480 (eb01341) into 8.0.0 (a745091) will increase coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            8.0.0    #2480      +/-   ##
==========================================
+ Coverage   88.27%   88.40%   +0.13%     
==========================================
  Files         178      178              
  Lines       15200    15209       +9     
  Branches     5280     5281       +1     
==========================================
+ Hits        13418    13446      +28     
+ Misses       1608     1588      -20     
- Partials      174      175       +1     
Impacted Files Coverage Δ
Sources/Sentry/SentryRequestOperation.m 71.42% <0.00%> (-9.53%) ⬇️
Sources/Sentry/SentryNetworkTracker.m 76.21% <0.00%> (+0.24%) ⬆️
Sources/Sentry/SentryUser.m 96.39% <0.00%> (+12.58%) ⬆️
Sources/Sentry/NSDictionary+SentrySanitize.m 75.00% <0.00%> (+33.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a745091...eb01341. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.94 ms 1248.26 ms 28.32 ms
Size 20.75 KiB 383.89 KiB 363.14 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
e2f1150 1220.39 ms 1249.94 ms 29.55 ms
ee127f4 1203.49 ms 1231.28 ms 27.79 ms
48c7211 1214.06 ms 1234.74 ms 20.68 ms
9ba19c0 1226.79 ms 1252.02 ms 25.23 ms
864c39a 1226.12 ms 1248.26 ms 22.13 ms
923362d 1197.73 ms 1232.20 ms 34.47 ms
3861500 1214.88 ms 1232.48 ms 17.60 ms
377c78b 1239.63 ms 1261.51 ms 21.88 ms
0fdf0b2 1266.27 ms 1277.90 ms 11.63 ms
09ad77e 1242.14 ms 1244.02 ms 1.88 ms

App size

Revision Plain With Sentry Diff
e2f1150 20.51 KiB 333.10 KiB 312.59 KiB
ee127f4 20.51 KiB 333.10 KiB 312.59 KiB
48c7211 20.75 KiB 374.72 KiB 353.97 KiB
9ba19c0 20.75 KiB 374.71 KiB 353.96 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
923362d 20.75 KiB 374.71 KiB 353.96 KiB
3861500 20.50 KiB 333.54 KiB 313.04 KiB
377c78b 20.50 KiB 337.71 KiB 317.20 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
09ad77e 20.50 KiB 339.01 KiB 318.51 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight armcknight merged commit dd2e101 into 8.0.0 Dec 2, 2022
@armcknight armcknight deleted the armcknight/fix/trending-movies-build branch December 2, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants