-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trending movies build #2480
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2480 +/- ##
==========================================
+ Coverage 88.27% 88.40% +0.13%
==========================================
Files 178 178
Lines 15200 15209 +9
Branches 5280 5281 +1
==========================================
+ Hits 13418 13446 +28
+ Misses 1608 1588 -20
- Partials 174 175 +1
Continue to review full report at Codecov.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2f1150 | 1220.39 ms | 1249.94 ms | 29.55 ms |
ee127f4 | 1203.49 ms | 1231.28 ms | 27.79 ms |
48c7211 | 1214.06 ms | 1234.74 ms | 20.68 ms |
9ba19c0 | 1226.79 ms | 1252.02 ms | 25.23 ms |
864c39a | 1226.12 ms | 1248.26 ms | 22.13 ms |
923362d | 1197.73 ms | 1232.20 ms | 34.47 ms |
3861500 | 1214.88 ms | 1232.48 ms | 17.60 ms |
377c78b | 1239.63 ms | 1261.51 ms | 21.88 ms |
0fdf0b2 | 1266.27 ms | 1277.90 ms | 11.63 ms |
09ad77e | 1242.14 ms | 1244.02 ms | 1.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2f1150 | 20.51 KiB | 333.10 KiB | 312.59 KiB |
ee127f4 | 20.51 KiB | 333.10 KiB | 312.59 KiB |
48c7211 | 20.75 KiB | 374.72 KiB | 353.97 KiB |
9ba19c0 | 20.75 KiB | 374.71 KiB | 353.96 KiB |
864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
923362d | 20.75 KiB | 374.71 KiB | 353.96 KiB |
3861500 | 20.50 KiB | 333.54 KiB | 313.04 KiB |
377c78b | 20.50 KiB | 337.71 KiB | 317.20 KiB |
0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
09ad77e | 20.50 KiB | 339.01 KiB | 318.51 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#2408 changed API that broke TrendingMovies but was not caught in CI due to invalid caching strategy (fixed in #2479 )
#skip-changelog