Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on iOS 16 using Xcode 14.0 #2147

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Run tests on iOS 16 using Xcode 14.0 #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00d1229
Run tests on iOS 16 using Xcode 14.0
kevinrenskers Sep 13, 2022
ff41bbb
Merge branch 'master' into tests/ios16
kevinrenskers Sep 13, 2022
2fe74f2
Fix for Xcode 14
kevinrenskers Sep 13, 2022
c6e8691
Fix regex
kevinrenskers Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ jobs:
xcode: "13.4.1"
test-destination-os: "latest"

# iOS 16
- runs-on: macos-12
platform: "iOS"
xcode: "14.0"
test-destination-os: "latest"

# macOS 11
- runs-on: macos-11
platform: "macOS"
Expand Down
4 changes: 2 additions & 2 deletions scripts/xcode-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ esac

echo "CONFIGURATION: $CONFIGURATION"

XCODE_MAJOR_VERSION=$(echo $XCODE | sed -E 's/([0-9]*)\.[0-9]*\.[0-9]*/\1/g')
XCODE_MAJOR_VERSION=$(echo $XCODE | sed -E 's/([0-9]*)\.[0-9]*\.?[0-9]+/\1/g')

if [ $PLATFORM == "iOS" -a $OS == "12.4" ]; then
# Skip some tests that fail on iOS 12.4.
Expand All @@ -64,7 +64,7 @@ if [ $PLATFORM == "iOS" -a $OS == "12.4" ]; then
-skip-testing:"SentryTests/SentrySDKTests/testMemoryFootprintOfAddingBreadcrumbs" \
-skip-testing:"SentryTests/SentrySDKTests/testMemoryFootprintOfTransactions" \
test | tee raw-test-output.log | xcpretty -t && exit ${PIPESTATUS[0]}
elif [ $XCODE_MAJOR_VERSION == "13" ]; then
elif [ $XCODE_MAJOR_VERSION == "13" ] || [ $XCODE_MAJOR_VERSION == "14" ]; then
# We can retry flaky tests that fail with the -retry-tests-on-failure option introduced in Xcode 13.
env NSUnbufferedIO=YES xcodebuild -retry-tests-on-failure -test-iterations 3 -workspace Sentry.xcworkspace \
-scheme Sentry -configuration $CONFIGURATION \
Expand Down