Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add extra app start span #1952

Merged
merged 16 commits into from
Jul 12, 2022
Merged

feat: Add extra app start span #1952

merged 16 commits into from
Jul 12, 2022

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jul 8, 2022 •
edited
Loading

📜 Description

Add __mod_init_func hook which gets called before main. With
this info we can add one more app start span.

Before
Screen Shot 2022-07-11 at 13 22 51

Now
Screen Shot 2022-07-12 at 10 19 59

💡 Motivation and Context

We need the __mod_init_func hook for #1897.

💚 How did you test it?

Unit tests, UI tests, and real devices.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@philipphofmann
feat: Add runtime init app start span
5c4cfba 
Add __mod_init_func hook which gets called before main. With
this info we can add one more app start span.
@philipphofmann
Merge branch 'master' into feat/main-mod-init
06f8f84
@github-actions
Copy link

github-actions bot commented Jul 8, 2022 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5dc7537

@philipphofmann philipphofmann changed the title feat: Add runtime init app start span feat: Add extra app start span Jul 12, 2022
@philipphofmann philipphofmann marked this pull request as ready for review July 12, 2022 07:21
brustolin
brustolin approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann
Copy link
Member Author

@brustolin, I changed a few things. Please have another look.

@brustolin
Copy link
Contributor

@brustolin, I changed a few things. Please have another look.

Looks good!!

@philipphofmann philipphofmann merged commit 252a8c2 into master Jul 12, 2022
@philipphofmann philipphofmann deleted the feat/main-mod-init branch July 12, 2022 12:04
kevinrenskers added a commit that referenced this pull request Jul 12, 2022
@kevinrenskers
Merge branch 'master' into feat/extra-controller-breadcrumb-data
beee960 
* master:
  ref: Mark options.sdkInfo as deprecated (#1960)
  feat: Add extra app start span (#1952)
kevinrenskers added a commit that referenced this pull request Jul 13, 2022
@kevinrenskers
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
56c19a7 
* master:
  fix: Crash in profiling logger (#1964)
  ref: Mark options.sdkInfo as deprecated (#1960)
  feat: Add extra app start span (#1952)
kevinrenskers added a commit that referenced this pull request Jul 13, 2022
@kevinrenskers
Merge branch 'master' into fix/1307-sanitze-span
c20efe8 
* master:
  fix: Crash in profiling logger (#1964)
  ref: Mark options.sdkInfo as deprecated (#1960)
  feat: Add extra app start span (#1952)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem left review comments

@brustolin brustolin Awaiting requested review from brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipphofmann @brustolin @Swatinem