Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider serializing transactions on a background thread #3826

Closed
philipphofmann opened this issue Apr 4, 2024 · 0 comments · Fixed by #3892
Closed

Consider serializing transactions on a background thread #3826

philipphofmann opened this issue Apr 4, 2024 · 0 comments · Fixed by #3892
Assignees
@philipphofmann
Labels
Platform: Cocoa

Comments

@philipphofmann
Copy link
Member

Description

Currently, we serialize and send the transaction on the calling thread of finish. https://github.com/getsentry/sentry-cocoa/blob/main/Sources/Sentry/SentryTracer.m#L596-L622

This sometimes leads to app hangs for some customers when the transaction is large and they have profiling enabled. Instead, we could serialize and send the transaction on a background thread.
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Apr 4, 2024
@philipphofmann philipphofmann moved this from Needs Discussion to Todo in Mobile & Cross Platform SDK Apr 10, 2024
@philipphofmann philipphofmann moved this from Todo to In Progress in Mobile & Cross Platform SDK Apr 24, 2024
philipphofmann added a commit that referenced this issue Apr 24, 2024
@philipphofmann
impr: Capture transactions on a bg thread
a9ad821 
Instead of capturing and serializing the transaction on the calling
thread, the SDK now does this on a background thread.

Fixes GH-3826
philipphofmann added a commit that referenced this issue Apr 24, 2024
@philipphofmann
impr: Capture transactions on a bg thread
c359fd5 
Instead of capturing and serializing the transaction on the calling
thread, the SDK now does this on a background thread.

Fixes GH-3826
philipphofmann added a commit that referenced this issue Apr 24, 2024
@philipphofmann
impr: Capture transactions on a bg thread
eacdf9c 
Instead of capturing and serializing the transaction on the calling
thread, the SDK now does this on a background thread.

Fixes GH-3826
This was referenced Apr 24, 2024
Merged
Open
philipphofmann added a commit that referenced this issue Apr 29, 2024
@philipphofmann
impr: Capture transactions on a bg thread (#3892)
38b36f5 
Instead of capturing and serializing the transaction on the calling
thread, the SDK now does this on a background thread.

Fixes GH-3826
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK Apr 29, 2024
dKasabwala pushed a commit to dKasabwala/sentry-cocoa that referenced this issue May 6, 2024
@philipphofmann
impr: Capture transactions on a bg thread (getsentry#3892)
0149923 
Instead of capturing and serializing the transaction on the calling
thread, the SDK now does this on a background thread.

Fixes getsentryGH-3826
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this issue May 21, 2024
@philipphofmann
impr: Capture transactions on a bg thread (getsentry#3892)
f02ecf6 
Instead of capturing and serializing the transaction on the calling
thread, the SDK now does this on a background thread.

Fixes getsentryGH-3826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Platform: Cocoa
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

impr: Capture transactions on a bg thread getsentry/sentry-cocoa
1 participant
@philipphofmann