Skip to content

Commit

Permalink
fix: Remove wrong error log in CoreDataTracker (#3894)
Browse files Browse the repository at this point in the history
The SentryCoreDataTracker logged an error for fetch requests when no
span was bound to the scope, which happens when no auto-generated
transaction is running. This is fixed now by removing that log.

Fixes GH-3586
  • Loading branch information
philipphofmann authored Apr 24, 2024
1 parent c02bb1f commit e0904ef
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Crash due to a background call to -[UIApplication applicationState] (#3855)
- Save framework without UIKit/AppKit as Github Asset for releases (#3858)
- Fix crash associated with runtime collision in global C function names (#3862)
- Remove wrong error log in SentryCoreDataTracker (#3894)

## 8.24.0

Expand Down
3 changes: 0 additions & 3 deletions Sources/Sentry/SentryCoreDataTracker.m
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ - (NSArray *)managedObjectContext:(NSManagedObjectContext *)context
SENTRY_LOG_DEBUG(@"SentryCoreDataTracker automatically started a new span with "
@"description: %@, operation: %@",
fetchSpan.description, fetchSpan.operation);
} else {
SENTRY_LOG_ERROR(
@"managedObjectContext:executeFetchRequest:error:originalImp: fetchSpan is nil.");
}

NSArray *result = original(request, error);
Expand Down

0 comments on commit e0904ef

Please sign in to comment.