fix: profiling app release version format (#2470)

* fix: list versions the same way they are reported elsewhere in sentry
getsentry · Dec 1, 2022 · d8c347f · d8c347f
1 parent a745091
commit d8c347f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ This version adds a dependency on Swift.
 - Increase `SentryCrashMAX_STRINGBUFFERSIZE` to reduce the instances where we're dropping a crash due to size limit (#2465)
 - `SentryAppStateManager` correctly unsubscribes from `NSNotificationCenter` when closing the SDK (#2460)
 - The SDK no longer reports an OOM when a crash happens after closing the SDK (#2468)
+- Use the preexisting app release version format for profiles (#2470)
 
 ### Breaking Changes
 

diff --git a/Sources/Sentry/SentryProfiler.mm b/Sources/Sentry/SentryProfiler.mm
@@ -548,12 +548,7 @@ - (void)captureEnvelope
     profile[@"platform"] = _transactions.firstObject.platform;
     profile[@"environment"] = _hub.scope.environmentString ?: _hub.getClient.options.environment;
     profile[@"timestamp"] = [[SentryCurrentDate date] sentry_toIso8601String];
-
-    const auto bundle = NSBundle.mainBundle;
-    profile[@"release"] =
-        [NSString stringWithFormat:@"%@ (%@)",
-                  [bundle objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey],
-                  [bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"]];
+    profile[@"release"] = _hub.getClient.options.releaseName;
 
 #    if SENTRY_HAS_UIKIT
     auto relativeFrameTimestampsNs = [NSMutableArray array];

diff --git a/Tests/SentryTests/Profiling/SentryProfilerSwiftTests.swift b/Tests/SentryTests/Profiling/SentryProfilerSwiftTests.swift
@@ -270,9 +270,10 @@ private extension SentryProfilerSwiftTests {
 
         XCTAssertEqual(transactionEnvironment, profile["environment"] as! String)
 
-        let version = Bundle.main.object(forInfoDictionaryKey: kCFBundleVersionKey as String) ?? "(null)"
-        let build = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") ?? "(null)"
-        let releaseString = "\(version) (\(build))"
+        let bundleID = Bundle.main.object(forInfoDictionaryKey: kCFBundleIdentifierKey as String) ?? "(null)"
+        let version = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") ?? "(null)"
+        let build = Bundle.main.object(forInfoDictionaryKey: kCFBundleVersionKey as String) ?? "(null)"
+        let releaseString = "\(bundleID)@\(version)+\(build)"
         XCTAssertEqual(profile["release"] as! String, releaseString)
 
         XCTAssertNotEqual(SentryId.empty, SentryId(uuidString: profile["profile_id"] as! String))