feat: Add a timeout for auto-generated transactions

Closes #1173
getsentry · Dec 14, 2022 · 29bde6c · 29bde6c
1 parent 53e149f
commit 29bde6c
Showing 1 changed file with 34 additions and 0 deletions.
diff --git a/Sources/Sentry/SentryTracer.m b/Sources/Sentry/SentryTracer.m
@@ -37,6 +37,7 @@
  */
 static const NSTimeInterval SENTRY_APP_START_MEASUREMENT_DIFFERENCE = 5.0;
 static const NSTimeInterval SENTRY_AUTO_TRANSACTION_MAX_DURATION = 500.0;
+static const NSTimeInterval SENTRY_AUTO_TRANSACTION_DEADLINE = 30.0;
 
 @interface
 SentryTracer ()
@@ -51,6 +52,7 @@
 @property (nonatomic) BOOL wasFinishCalled;
 @property (nonatomic) NSTimeInterval idleTimeout;
 @property (nonatomic, nullable, strong) SentryDispatchQueueWrapper *dispatchQueueWrapper;
+@property (nonatomic, nullable, strong) NSTimer *deadlineTimer;
 
 @end
 
@@ -166,6 +168,10 @@ - (instancetype)initWithTransactionContext:(SentryTransactionContext *)transacti
             [self dispatchIdleTimeout];
         }
 
+        if ([self isAutoGeneratedTransaction]) {
+            [self startDeadlineTimer];
+        }
+
 #if SENTRY_HAS_UIKIT
         _startTimeChanged = NO;
 
@@ -217,6 +223,33 @@ - (void)cancelIdleTimeout
     }
 }
 
+- (void)startDeadlineTimer
+{
+    self.deadlineTimer = [NSTimer scheduledTimerWithTimeInterval:SENTRY_AUTO_TRANSACTION_DEADLINE
+                                                          target:self
+                                                        selector:@selector(deadlineTimerFired)
+                                                        userInfo:nil
+                                                         repeats:NO];
+}
+
+- (void)deadlineTimerFired
+{
+    @synchronized(_children) {
+        for (id<SentrySpan> span in _children) {
+            if (![span isFinished])
+                [span finishWithStatus:kSentrySpanStatusDeadlineExceeded];
+        }
+    }
+
+    [self finishWithStatus:kSentrySpanStatusDeadlineExceeded];
+}
+
+- (void)cancelDeadlineTimer
+{
+    [self.deadlineTimer invalidate];
+    self.deadlineTimer = nil;
+}
+
 - (id<SentrySpan>)getActiveSpan
 {
     id<SentrySpan> span;
@@ -485,6 +518,7 @@ - (void)finishWithStatus:(SentrySpanStatus)status
     self.wasFinishCalled = YES;
     _finishStatus = status;
     [self cancelIdleTimeout];
+    [self cancelDeadlineTimer];
     [self canBeFinished];
 }