Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

szokeasaurusrex/windows static link test #2207

Closed
wants to merge 5 commits into from
Closed

szokeasaurusrex/windows static link test #2207

wants to merge 5 commits into from

Conversation

szokeasaurusrex
Copy link
Member

  • ci(windows): Check release binary during release build
  • run on pr:
  • Only run what is needed to check binary
  • remove redundant || exit 1
  • build(windows): Statically link CRT on Windows

@szokeasaurusrex
ci(windows): Check release binary during release build
d32e9dc 
Fail the release build on Windows if `sentry-cli.exe --help` exits with nonzero status
@szokeasaurusrex
run on pr:
2e383b6
@szokeasaurusrex
Only run what is needed to check binary
77b78a0
@szokeasaurusrex
remove redundant || exit 1
43be040
@szokeasaurusrex
build(windows): Statically link CRT on Windows
84ef9f0 
Statically link the CRT on Windows. This eliminates Sentry CLI's dependency on `VCRUNTIME140.dll`, allowing Sentry CLI to be run on a clean install of Windows, without requiring any external dependencies.

Fixes #2193
Closes #2201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szokeasaurusrex