Add method to add breadcrumb with string parameter.

[maciejwalkowiak]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

Add method to add breadcrumb with string parameter.

💡 Motivation and Context

See #499 (comment)

💚 How did you test it?

There's a unit test.

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing
• No breaking changes

🔮 Next steps

[bruno-garcia]

👍

[bruno-garcia]

Oh, what about this also going to master?

[maciejwalkowiak]

I'm good if it goes to master. I took today's discussion of not breaking Android build seriously 🙂

Switching base is unfortunately not as straightforward. If @marandaneto has no objections I'll close this one and create another PR against master tomorrow morning.

[bruno-garcia]

Makes sense to be on the safe side.

This is just an overload so not a breaking change though
For sure Android users can take advantage also, so would be nice.

I believe the main concern are things that would need to be tested on different Android version (yup) to make sure things continue to work. Because, Android.

Things like this overload IMO are safe and will make it simpler later for us to merge things from the java branch and master since a lot of code not ok to merge into master will follow.

@marandaneto thoughts?

[marandaneto]

Makes sense to be on the safe side.

This is just an overload so not a breaking change though
For sure Android users can take advantage also, so would be nice.

I believe the main concern are things that would need to be tested on different Android version (yup) to make sure things continue to work. Because, Android.

Things like this overload IMO are safe and will make it simpler later for us to merge things from the java branch and master since a lot of code not ok to merge into master will follow.

@marandaneto thoughts?

yep, agreed, it's just an overload, things like this are LGTM

[maciejwalkowiak]

Closed in favour of #501.