Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fix: deserialise unmapped contexts values from envelope #470

Merged
merged 3 commits into from
Jun 25, 2020
Merged

fix: deserialise unmapped contexts values from envelope #470

merged 3 commits into from
Jun 25, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 24, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fix: deserialise unmapped contexts values from envelope

💡 Motivation and Context

contexts fields were missing from a react native event

💚 How did you test it?

unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@marandaneto marandaneto requested a review from jennmueng June 24, 2020 07:31
@marandaneto marandaneto changed the title fix: par unmapped contexts values from envelope fix: deserialise unmapped contexts values from envelope Jun 24, 2020
Copy link
Member

@jennmueng jennmueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note but other than that LGTM! 💯

@marandaneto marandaneto merged commit e96cb0a into getsentry:master Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants