This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDEA’s gradle support failed to inherit language/bytecode level from
parent project, causing mockito failures w/ 11 bytecode.
📢 Type of change
📜 Description
Explicitly set Java / JVM versions for the
sentry-core
subproject.💡 Motivation and Context
Technically it doesn’t fix a Sentry bug but rather papers over a bug in IDEA 2020.1.2 which makes tests fail from the IDE: It doesn’t detect the source & target JVM versions from the parent project. Then it generates JVM 11 bytecode, which our Mockito can’t handle.
💚 How did you test it?
Reimported in IDEA 2020.1.2 and saw that the JVM versions were now correct in the settings & the tests were green.
Had some tests that did not seem to deliver any result (green or red) in AS 4.0 but this did not change after reverting this change locally so it’s at least unrelated.
📝 Checklist
🔮 Next steps