Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

do not add automatic and empty sensor breadcrumbs #401

Merged
merged 2 commits into from
May 11, 2020
Merged

do not add automatic and empty sensor breadcrumbs #401

merged 2 commits into from
May 11, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 10, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

do not add automatic and empty sensor breadcrumbs

💡 Motivation and Context

inspired by #400

💚 How did you test it?

ran it

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

find out how to avoid @Ignore test, tried mocking, reflection, hacking private-package but still SensorEvent.values is always null, maybe because of UnsupportedAppUsage in the ctor.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4648425). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #401   +/-   ##
=========================================
  Coverage          ?   59.84%           
  Complexity        ?      790           
=========================================
  Files             ?       89           
  Lines             ?     3621           
  Branches          ?      350           
=========================================
  Hits              ?     2167           
  Misses            ?     1302           
  Partials          ?      152           
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/io/sentry/core/SentryEvent.java 69.91% <0.00%> (ø) 54.00% <0.00%> (?%)
...rc/main/java/io/sentry/core/protocol/Contexts.java 4.76% <0.00%> (ø) 1.00% <0.00%> (?%)
.../src/main/java/io/sentry/core/SendCachedEvent.java 59.09% <0.00%> (ø) 8.00% <0.00%> (?%)
...re/src/main/java/io/sentry/core/SentryOptions.java 78.80% <0.00%> (ø) 70.00% <0.00%> (?%)
...try-core/src/main/java/io/sentry/core/Session.java 92.59% <0.00%> (ø) 28.00% <0.00%> (?%)
...ore/src/main/java/io/sentry/core/SentryValues.java 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...rc/main/java/io/sentry/core/SynchronizedQueue.java 18.18% <0.00%> (ø) 3.00% <0.00%> (?%)
...in/java/io/sentry/core/hints/SessionStartHint.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...e/src/main/java/io/sentry/core/NoOpSerializer.java 50.00% <0.00%> (ø) 4.00% <0.00%> (?%)
...main/java/io/sentry/core/util/CollectionUtils.java 14.28% <0.00%> (ø) 1.00% <0.00%> (?%)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4648425...162b4d8. Read the comment docs.

@marandaneto marandaneto merged commit a964978 into getsentry:master May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants