Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

enha: only set breadcrumb extras if not empty #394

Merged
merged 1 commit into from
May 7, 2020
Merged

enha: only set breadcrumb extras if not empty #394

merged 1 commit into from
May 7, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 7, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

enha: only set breadcrumb extras if not empty

💡 Motivation and Context

sending empty extras is non sense

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@marandaneto marandaneto changed the title only set breadcrumb extras if not empty enha: only set breadcrumb extras if not empty May 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #394   +/-   ##
=========================================
  Coverage     59.79%   59.79%           
  Complexity      789      789           
=========================================
  Files            89       89           
  Lines          3621     3621           
  Branches        350      350           
=========================================
  Hits           2165     2165           
  Misses         1304     1304           
  Partials        152      152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9979618...63fa0d5. Read the comment docs.

@marandaneto marandaneto merged commit 5569c0c into getsentry:master May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants