Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

enhancement: use AGP 4 features #366

Merged
merged 11 commits into from
May 29, 2020
Merged

enhancement: use AGP 4 features #366

merged 11 commits into from
May 29, 2020

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

use AGP 4 features

💡 Motivation and Context

a lot of improvements.

💚 How did you test it?

CI is green

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fd13b36). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #366   +/-   ##
=========================================
  Coverage          ?   59.96%           
  Complexity        ?      812           
=========================================
  Files             ?       93           
  Lines             ?     3742           
  Branches          ?      363           
=========================================
  Hits              ?     2244           
  Misses            ?     1343           
  Partials          ?      155           
Impacted Files Coverage Δ Complexity Δ
...n/java/io/sentry/core/transport/HttpTransport.java 73.73% <0.00%> (ø) 31.00% <0.00%> (?%)
.../src/main/java/io/sentry/core/SystemOutLogger.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...re/src/main/java/io/sentry/core/util/LogUtils.java 70.00% <0.00%> (ø) 4.00% <0.00%> (?%)
...entry-core/src/main/java/io/sentry/core/Scope.java 86.17% <0.00%> (ø) 34.00% <0.00%> (?%)
sentry-core/src/main/java/io/sentry/core/Hub.java 65.06% <0.00%> (ø) 59.00% <0.00%> (?%)
...java/io/sentry/core/transport/AsyncConnection.java 68.50% <0.00%> (ø) 19.00% <0.00%> (?%)
sentry-core/src/main/java/io/sentry/core/Dsn.java 94.11% <0.00%> (ø) 12.00% <0.00%> (?%)
...e/src/main/java/io/sentry/core/SentryItemType.java 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...rc/main/java/io/sentry/core/protocol/Contexts.java 4.76% <0.00%> (ø) 1.00% <0.00%> (?%)
...core/src/main/java/io/sentry/core/SentryLevel.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd13b36...c7b8666. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review May 29, 2020 06:53
@marandaneto marandaneto changed the title use AGP 4 features enhancement: use AGP 4 features May 29, 2020
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit cc07701 into getsentry:master May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants