Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

check for androidx availability on runtime #356

Merged
merged 2 commits into from
Apr 15, 2020
Merged

check for androidx availability on runtime #356

merged 2 commits into from
Apr 15, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 15, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

check for androidx availability on runtime

💡 Motivation and Context

if you don't want to use the release health feature, you actually can exclude it.
just to avoid an error if you have enabled it and can't use androidx, we check on runtime via reflection.

💚 How did you test it?

running it/build.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #356 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
- Coverage     58.97%   58.95%   -0.02%     
- Complexity      758      759       +1     
============================================
  Files            87       87              
  Lines          3534     3538       +4     
  Branches        338      340       +2     
============================================
+ Hits           2084     2086       +2     
- Misses         1300     1301       +1     
- Partials        150      151       +1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/sentry/core/cache/SessionCache.java 55.73% <0.00%> (-0.69%) 23.00% <0.00%> (ø%)
...c/main/java/io/sentry/core/DirectoryProcessor.java 69.38% <0.00%> (+2.04%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a24d4...a41d751. Read the comment docs.

@marandaneto marandaneto merged commit 720f249 into getsentry:master Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants