Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

set current threadId when theres no mechanism to rely on #277

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Feb 21, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

set current threadId when theres no mechanism to rely on.

💡 Motivation and Context

exception had no threadId if it was not a exception mechanism and this makes the thread selector not happy on the dashboard.

💚 How did you test it?

unit test and debugging it.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to send it anyway but ideally the front end wouldn't rely on having thread id at all and just show the exception component.

@marandaneto
Copy link
Contributor Author

makes sense to send it anyway but ideally the front end wouldn't rely on having thread id at all and just show the exception component.

yep I agree, but if you do send exception + threads, it should be like this so the current behavior would work without changes on the frontend.

@marandaneto marandaneto merged commit c3785de into master Feb 21, 2020
@marandaneto marandaneto deleted the fix/exception_threadid branch February 21, 2020 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants