Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

added executor for caching values out of the main thread #201

Merged
merged 5 commits into from
Dec 17, 2019

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

added executor for caching values out of the main thread.

💡 Motivation and Context

right now every capture exception or message will do IO on the main thread and data is static, so it may be cached.

💚 How did you test it?

executing and StrictMode.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #201   +/-   ##
========================================
  Coverage      57.9%   57.9%           
  Complexity      547     547           
========================================
  Files            72      72           
  Lines          2613    2613           
  Branches        228     228           
========================================
  Hits           1513    1513           
  Misses          983     983           
  Partials        117     117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe9dc6...cc4dbbc. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff!

@marandaneto marandaneto marked this pull request as ready for review December 13, 2019 17:04
@marandaneto
Copy link
Contributor Author

This is great stuff!

file storage stats are still IO, we could do it async, but we will need to do await anyway, not sure if its worth it.
file storage stats would need to be checked every event anyway as it could be the source of the exception.

@bruno-garcia bruno-garcia merged commit 1a8bbd7 into master Dec 17, 2019
@bruno-garcia bruno-garcia deleted the enha/context_no_IO branch December 17, 2019 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants