Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

ref: Drop errored in favor of crashed #187

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Dec 5, 2019

We've discussed in today's TSC that it wont' be possible to introduce errored and have crashed mean that in fact the app was terminated (what most people understand crash means). That's mainly due to backwards compat (old SDKs will send crashed=true meaning erroed, for years). So we're accepting that crashed=true means errored and not necessarily a hard crash.

We'll compensate in the server normalization or worst case in the UI to indicate that this flag means this was the errored thread as opposed to this thread crashed the process

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #187 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #187     +/-   ##
==========================================
- Coverage        58%   57.9%   -0.1%     
+ Complexity      551     543      -8     
==========================================
  Files            72      72             
  Lines          2617    2599     -18     
  Branches        235     228      -7     
==========================================
- Hits           1518    1505     -13     
+ Misses          978     977      -1     
+ Partials        121     117      -4
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/sentry/core/MainEventProcessor.java 70% <ø> (+6.58%) 6 <0> (-1) ⬇️
...ain/java/io/sentry/core/protocol/SentryThread.java 70.37% <ø> (-2.97%) 12 <0> (-2)
.../main/java/io/sentry/core/SentryThreadFactory.java 100% <100%> (ø) 6 <0> (-4) ⬇️
...core/src/main/java/io/sentry/core/SentryEvent.java 66.66% <0%> (-1.02%) 38% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b34e5f...f80a4e8. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 6f3e420 into master Dec 5, 2019
@bruno-garcia bruno-garcia deleted the ref/drop-erroroed branch December 5, 2019 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants