-
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
============================================
+ Coverage 57.73% 57.77% +0.03%
- Complexity 526 527 +1
============================================
Files 72 72
Lines 2522 2522
Branches 223 223
============================================
+ Hits 1456 1457 +1
Misses 958 958
+ Partials 108 107 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@marandaneto can we try on the sample? to consume the bits? |
the sample won't work because it's referencing the project directly and not a maven dependency. for this sample, as they are under the same project, we would need to reference the project in the CMakeLists.txt manually as we do on sentry-android-ndk/sentry-native. |
is it possible to run a maven install on local maven on build, and on the sample consume from maven local (as opposed to a reference to a project?) |
yes, I thought to do that, but then we lose debugging. |
📢 Type of change
📜 Description
adding 3rd plugin that copies headers and extracts fat aar.
one will need to:
Apply the plugin in the App:
apply plugin: 'com.ydq.android.gradle.native-aar.import'
Reference the extracted binaries in their
CMakeLists.txt
:Include the header in their c files:
#include <sentry.h>
💡 Motivation and Context
it's not possible to include sentry.h from native code at the moment, that will make it possible.
💚 How did you test it?
deploying to maven local and including sentry.h and capturing an issue.
📝 Checklist
🔮 Next steps
create a sample of how to include the 3rd plugin and include the headers