Support Room kotlin gencode #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated Room lib, kotlin version and compiler added new test to the repo
added new Room classes (generated through ksp) to VisitorTest
stefanosiano
requested review from
markushi,
romtsn and
adinauer
as code owners
fixed imports moved VisitorTest classes into specific folder
romtsn
reviewed
Jan 15, 2024
| ) { | ||
| super.visitMethodInsn(opcode, owner, name, descriptor, isInterface) | ||
| // The backend binds the exception to the current span, via tracing without performance, so we don't need any special try/catch management. | ||
| if (opcode == Opcodes.INVOKEVIRTUAL) { |
There was a problem hiding this comment.
hrm, does INVOKEVIRTUAL work with the CLOSE method? It used to be INVOKEINTERFACE before
There was a problem hiding this comment.
nice catch!
I updated the instrumentation to take the method type into consideration and updated the condition for the close method
romtsn
approved these changes
Jan 15, 2024
…n when instrumenting its methods
…ix/room-generate-kotlin
…n when instrumenting its methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
removed try catch from room instrumentation, as TWP (Tracing Without Performance) makes it useless
added new Room classes (generated through ksp) to VisitorTest
In order to use new Room version and ksp, i had to update agp, gradle, kotlin, room, sdk and kotlin compiler versions
💡 Motivation and Context
Fixes #585
Also, removing all try/catch management from Room instrumentation makes it simpler and more robust
💚 How did you test it?
Added classes generated with ksp to VisitorTest
📝 Checklist
🔮 Next steps