Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider sentry-bom version for auto-install #625

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Consider sentry-bom version for auto-install #625

merged 2 commits into from
Jan 8, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 7, 2024

📜 Description

💡 Motivation and Context

Closes #603

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

adinauer
adinauer approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn merged commit 5861c59 into main Jan 8, 2024
17 checks passed
@romtsn romtsn deleted the rz/feat/sentry-bom-autoinstall branch January 8, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

findSentryVersion not detecting applied sdk version
2 participants
@romtsn @adinauer