Analytics / Telemetry #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
romtsn
reviewed
Oct 23, 2023
romtsn
reviewed
Oct 23, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 15, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/AppConfig.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 15, 2023
| BuildOperationListener, | ||
| AutoCloseable { | ||
|
|
||
| private var hub: IHub = NoOpHub.getInstance() |
There was a problem hiding this comment.
m: I believe all of this should be atomic, because it can be accessed by multiple tasks in parallel as mentioned here https://docs.gradle.org/current/javadoc/org/gradle/api/services/BuildService.html
romtsn
reviewed
Nov 15, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 15, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 15, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 15, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt
Show resolved
Hide resolved
romtsn
reviewed
Nov 15, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Nov 15, 2023
|
Oh and maybe one more thing - maybe we should have at least one test that disables telemetry and verifies that the hub is no-op (or just a log message at least) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
We now send telemetry data unless a self hosted
urlhas been set. This can be disabled via thetelemetryoption.💡 Motivation and Context
Closes #223
💚 How did you test it?
Manually using samples
📝 Checklist
🔮 Next steps