-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload end of log as breadcrumbs, use exceptions and stacktrace #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatyping
commented
Oct 22, 2022
emmatyping
commented
Oct 22, 2022
emmatyping
commented
Oct 22, 2022
hubertdeng123
approved these changes
Oct 24, 2022
lgtm |
This was referenced Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we change the send-event function to write out more information into the envelope we send via
sentry-cli
, particularly adding breadcrumbs with the end of the log and giving the stack trace in a format Sentry self-hosted can understand.Fixes getsentry/team-ospo#54 and getsentry/team-ospo#53
Example issue with this formatting: https://self-hosted.getsentry.net/organizations/self-hosted/issues/227/?query=is%3Aunresolved
Also a cheat sheet for
jq
arguments:-c
collapses to 1 line-n
means null input (we're just constructing JSON, not mangling it)-s
is "slurp" JSON lines into an array.--arg
can be used to write object arguments--argjson
is like--arg
, but takes JSON expressions as the argument!