Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload end of log as breadcrumbs, use exceptions and stacktrace #1775

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

emmatyping
Copy link
Contributor

@emmatyping emmatyping commented Oct 22, 2022

In this PR, we change the send-event function to write out more information into the envelope we send via sentry-cli, particularly adding breadcrumbs with the end of the log and giving the stack trace in a format Sentry self-hosted can understand.

Fixes getsentry/team-ospo#54 and getsentry/team-ospo#53
Example issue with this formatting: https://self-hosted.getsentry.net/organizations/self-hosted/issues/227/?query=is%3Aunresolved

Also a cheat sheet for jq arguments:

  • -c collapses to 1 line
  • -n means null input (we're just constructing JSON, not mangling it)
  • -s is "slurp" JSON lines into an array.
  • --arg can be used to write object arguments
  • --argjson is like --arg, but takes JSON expressions as the argument!

install/error-handling.sh Outdated Show resolved Hide resolved
@emmatyping emmatyping marked this pull request as ready for review October 24, 2022 20:41
@emmatyping emmatyping enabled auto-merge (squash) October 24, 2022 21:09
@emmatyping emmatyping disabled auto-merge October 24, 2022 21:11
@hubertdeng123
Copy link
Member

lgtm

@emmatyping emmatyping merged commit 3a07ff4 into master Oct 26, 2022
@emmatyping emmatyping deleted the ethanhs/send-breadcrumb branch October 26, 2022 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include tracebacks as first-class in error monitoring
2 participants