-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced README with Instructions! #12
Conversation
I don't know if I like this super opinionated approach to the database backups and how to run a TLS proxy. Neither of those things are projects we'd want to officially endorse in order to run Sentry. |
I guess I'd say, this feels more like an exercise for a blog post, rather than, "How to run Sentry." Since neither of those are core components and there are many opinions on how to do those things correctly, neither of which I'd feel comfortable putting an official stamp on, since that means we're endorsing and condoning. Not necessarily that I think they're bad. I just don't agree this is the place for that. |
I do see what you mean. Just fyi, I'm not trying to push one thing or another, I just want to help people get ideas flowing for how they can better utilize other projects to enhance their Sentry installs based on the DevOp toolsets of modern application delivery. Here's a couple ideas on how to change those around: We can either do something like (a short message prior to those sections):
Or I can just drop those sections down to something much more simplified (instead of the recommendation of a certain project and conf. details), we would have:
I don't mind either way ;) |
Yeah, I understand. :) I would love to have more opinionated documentation out there, but as it is, this should be the core. However others want to scale out or "productionize" their installs is up to them. To me, this falls under the same as us suggesting say, "Run this on Carina." Sure, that works, but it will also work other ways.
I'm ok with a light recommendation around TLS, just because I feel that's important. I also have no idea what Caddy is, so I'd never mention that in our docs. HAProxy and nginx are both fine. And definitely remove the database backup thing, because that's just normal infrastructure common sense. You want to backup your database, so figure it out. There's plenty of documentation on it and many different ways to accomplish it. It's also very likely that they're not running Postgres inside of a container as well. |
^^ ;) |
|
||
1. `mkdir -p data/{sentry,postgres}` - Make our local database and sentry config directories. | ||
This directory is bind-mounted with postgres so you don't lose state! | ||
2. `docker-compose run web config generate-secret-key` - Generate a secret key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t we use --rm
to avoid leaving containers lying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes! Just committed the addition. Thanks for pointing that out!
I’m also running a production instance of Sentry, using roughly the same steps as this PR suggests. In case this helps, here is mine (orchestrated using Ansible)
|
|
||
If you'd like to protect your Sentry install with SSL/TLS, there are | ||
fantastic SSL/TLS proxies like [HAProxy](http://www.haproxy.org/) | ||
and [Nginx](https://www.nginx.com/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to nginx.org
plz. nginx.com is the commercial entity, and nginx.org is the open source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
As you can tell, I'm completely noob to this new fancy review system Github has. |
So I've made the requested changes and this has been sitting for over a week here. Is there anything else I'm supposed to do? |
Sorry about that, we have a lot of repositories. 😛 |
Enhanced README with Instructions!
This is a PR adding instructions around utilizing the contents of this repository to lift a fully working Sentry install on Docker. It fills some gaps that the current docker related docs don't cover.
This is a bit more informative than #5 and covers some of the concerns in #2