Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts): Forgot to include 3.8 typings dirs in files #199

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix(ts): Forgot to include 3.8 typings dirs in files #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
017c2e4
fix(ts): Forgot to include 3.8 typings dirs in `files`
billyvg Jun 12, 2024
085bb97
add typings to gitignore
billyvg Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,8 @@ dist

# `.yarn/install-state.gz` is an optimization file that you shouldn't ever have to commit.
# It simply stores the exact state of your project so that the next commands can boot without having to resolve your workspaces all over again.
.yarn/install-state.gz
.yarn/install-state.gz

typings
typings-ts3.8
dist-ts3.8
3 changes: 2 additions & 1 deletion packages/rrweb-snapshot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
"dist",
"lib",
"es",
"typings"
"typings",
"typings-ts3.8"
],
"author": "[email protected]",
"license": "MIT",
Expand Down
3 changes: 2 additions & 1 deletion packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@
},
"files": [
"build",
"dist"
"dist",
"dist-ts3.8"
Comment on lines +51 to +52
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to change the naming of dist since that's what they used upstream

],
"devDependencies": {
"vite": "^3.2.0-beta.2",
Expand Down
Loading