Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the order of dependencies installation to ensure that
urllib3
is not overwritten. Otherwise we have an issue that we do not testurllib3<2
@markstory
I do not feel super comfortable with the order of installation of packages. In theory we can end up that we have artificial packages meaning that we override those packages that are specified in
setup.py
and we test not the real package.from CI I see the following error
for me it feels that we still have to drop urllib3<2 since the upstream is moving towards it.