Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coverage on master #677

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

beliaev-maksim
Copy link
Collaborator

@beliaev-maksim beliaev-maksim commented Oct 4, 2023

change the order of dependencies installation to ensure that urllib3 is not overwritten. Otherwise we have an issue that we do not test urllib3<2

@markstory
I do not feel super comfortable with the order of installation of packages. In theory we can end up that we have artificial packages meaning that we override those packages that are specified in setup.py and we test not the real package.

from CI I see the following error

types-requests 2.31.0.7 requires urllib3>=2

for me it feels that we still have to drop urllib3<2 since the upstream is moving towards it.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
responses/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@beliaev-maksim
Copy link
Collaborator Author

CI fails on the coverage, it is clear that urllib3 is overwritten by 2.x instead of 1.x

I will have a look

@beliaev-maksim beliaev-maksim mentioned this pull request Oct 4, 2023
@beliaev-maksim beliaev-maksim changed the title fix mypy on master fix mypy and coverage on master Oct 4, 2023
@beliaev-maksim beliaev-maksim changed the title fix mypy and coverage on master fix coverage on master Oct 4, 2023
@markstory markstory merged commit 9c0d1ac into getsentry:master Oct 4, 2023
@beliaev-maksim beliaev-maksim deleted the mbeliaev/fix_mypy2 branch October 5, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants