perf(buffer): Move system check to precondition #4275
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Nov 21, 2024
| @@ -775,4 +756,20 @@ mod tests { | |||
| 5 | |||
| ); | |||
| } | |||
|
|
|||
| #[tokio::test(start_paused = true)] | |||
| async fn precondition_no_future() { | |||
There was a problem hiding this comment.
Suggested change
| async fn precondition_no_future() { | |
| async fn precondition_no_poll() { |
jjbayer
commented
Nov 21, 2024
| @@ -434,7 +414,7 @@ impl Service for EnvelopeBufferService { | |||
| // On the one hand, we might want to prioritize dequeuing over enqueuing | |||
| // so we do not exceed the buffer capacity by starving the dequeue. | |||
| // on the other hand, prioritizing old messages violates the LIFO design. | |||
| Some(permit) = self.ready_to_pop(&buffer, dequeue.load(Ordering::Relaxed)) => { | |||
| Some(permit) = self.ready_to_pop(), if should_dequeue.load(Ordering::Relaxed) && self.system_ready(&buffer) => { | |||
There was a problem hiding this comment.
Note: with this, we should probably have a default sleep in the main loop to prevent busy looping or breaking out of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce overhead on the buffer service by checking preconditions for dequeueing without polling a future.
#skip-changelog