Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(system): Spawn with custom task ID #4262

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

ref(system): Spawn with custom task ID #4262

wants to merge 31 commits into from

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Nov 18, 2024 •
edited
Loading

Allow spawning a task with a service name:

relay_system::spawn(TaskId::for_service::<MyService>(), async {});

This is used when spanning a service.

#skip-changelog

jjbayer and others added 25 commits November 13, 2024 15:13
@jjbayer
rm start_in
3fab72e
@jjbayer
wip: easy cases
ff88466
@jjbayer
spawn
45f580a
@jjbayer
clean
4b2c4f9
@jjbayer
wip: service runner
20e403c
@jjbayer
update usage
d246af0
@jjbayer
fix remaining 2
ffa83ca
@jjbayer
lint
97cd873
@jjbayer
Merge remote-tracking branch 'origin/master' into joris/join
ced514b
@jjbayer
doc
a9a5b6d
@jjbayer
lint
0a28e44
@jjbayer
health check
d6bbdcc
@jjbayer
changelog
d0b4af9
@jjbayer @loewenheim
Update relay-server/src/services/projects/source/mod.rs
e885bda 
Co-authored-by: Sebastian Zivota <[email protected]>
@jjbayer
start_with
2260462
@jjbayer
naming
61a8c14
@jjbayer
Merge remote-tracking branch 'origin/master' into joris/panic-unhealthy
5803f9e
@jjbayer
merge
ad28282
@jjbayer
Revert "health check"
82729a8 
This reverts commit d6bbdcc.
@jjbayer
Merge remote-tracking branch 'origin/joris/join' into joris/join
f92a26d
@jjbayer
push
740bc33
@jjbayer
Revert "changelog"
d46f370 
This reverts commit d0b4af9.
@jjbayer
Merge remote-tracking branch 'origin/master' into joris/join
1af06f1
@jjbayer
ref(system): Spawn with custom task ID
491b7e1
@jjbayer
lint
bea8db8
@jjbayer jjbayer marked this pull request as ready for review November 18, 2024 12:34
@jjbayer jjbayer requested a review from a team as a code owner November 18, 2024 12:34
Dav1dde
Dav1dde approved these changes Nov 18, 2024
View reviewed changes
relay-system/src/runtime.rs Outdated Show resolved Hide resolved
relay-system/src/runtime.rs Outdated Show resolved Hide resolved
relay-system/src/service.rs Outdated Show resolved Hide resolved
@jjbayer jjbayer requested a review from Dav1dde November 18, 2024 13:22
Base automatically changed from joris/join to master November 19, 2024 07:22
Dav1dde
Dav1dde approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees

@jjbayer jjbayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjbayer @Dav1dde