feat(general): Add unknown SessionStatus variant #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBS1996
changed the title
olksdr
reviewed
Jan 12, 2023
There was a problem hiding this comment.
Overall looks ok.
The thing which bothers me it the way test is written, with a lot of indirections.
I would personally prefer to have test be more explicit with to see what actually is tested.
In current test I have to jump from one function to another, then to the custom type, and back again to see what place in the huge tuple is what and what is changed.
I my opinion test should be written as explicitly as possible and be more descriptive, which also could serve as the example of how to use some pieces of code.
olksdr
reviewed
Jan 13, 2023
9 tasks
olksdr
approved these changes
Jan 16, 2023
Co-authored-by: Oleksandr <[email protected]>
Co-authored-by: Oleksandr <[email protected]>
Co-authored-by: Oleksandr <[email protected]>
jan-auer
added a commit
that referenced
this pull request
Jan 18, 2023
* master: (35 commits) ref(actix): Migrate ProjectUpstream to `relay_system::Service` (#1727) feat(general): Add unknown SessionStatus variant (#1736) ref: Convert integration tests about dropping transactions to unit tests (#1720) release: 0.8.16 ci: Skip redundant self-hosted E2E on library release (#1755) doc(changelog): Add relevant changes to python changelog (#1753) feat(profiling): Add profile context (#1748) release: 23.1.0 profiling(fix): use an unpadded base64 encoding (#1749) Revert "feat(replays): Enable PII scrubbing for all organizations" (#1747) feat: Switch from base64 to data-encoding (#1743) instr(replays): Add timer metric to recording processing (#1742) feat(replays): Use Annotated struct definition for replay-event parsing (#1582) feat(sessions): Retire session duration metric (#1739) feat(general): Scrub all fields with IP address (#1725) feat(replays): Enable PII scrubbing for all organizations (#1678) chore(project): Add backoff mechanism for fetching projects (#1726) feat(profiling): Add new measurement units for profiling (#1732) chore(toolchain): update rust to 1.66.1 (#1735) ref(actix): Migrate server actor to the "service" arch (#1723) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an unknown field to SessionStatus enum. This is for cases where a user has an outdated relay and receives an enum variant not in his version of relay. In those cases the name of the enum will be stored in a string and be passed on.
#1639
#skip-changelog