Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redis): Do not PING on every connection access [INC-192] #1394

Merged
merged 3 commits into from
Aug 9, 2022
Merged

fix(redis): Do not PING on every connection access [INC-192] #1394

merged 3 commits into from
Aug 9, 2022

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Aug 8, 2022 •
edited
Loading

The vast majority of Redis commands issued by Relay is PING. This
command is used internally to verify that the connection is still alive.
The pooled connection implementation runs this check every time a
connection is grabbed from the pool.

This behavior can be disabled via test_on_check_out.

See INC-192

@jan-auer jan-auer changed the title fix(redis): Do not PING on every connection access fix(redis): Do not PING on every connection access [INC-192] Aug 8, 2022
@jan-auer
Copy link
Member Author

jan-auer commented Aug 8, 2022 •
edited
Loading

Still needs verification that Relay can handle a move of the Redis primary.

jan-auer added 2 commits August 8, 2022 22:52
@jan-auer
Merge branch 'master' into release/fix-redis-ping
4a663b7 
* master:
  fix(store): Serialize default transaction source (#1387)
  feat(schema): Add missing fields to DeviceContext (#1383)
  ref(server): Split EnvelopeManager file into smaller parts (#1388)
  ref(metrics): Remove `light_normalize` in favor of `light_normalize_event` (#1385)
@jan-auer
meta: Changelog
404015e
@jan-auer jan-auer mentioned this pull request Aug 8, 2022
Closed
@jan-auer jan-auer marked this pull request as ready for review August 8, 2022 20:57
@jan-auer jan-auer requested review from a team and beezz August 8, 2022 20:57
@jan-auer jan-auer self-assigned this Aug 8, 2022
jjbayer
jjbayer approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what happens when we check out an unhealthy connection after this change?

@jan-auer
Copy link
Member Author

jan-auer commented Aug 9, 2022

@beezz is going to test this with me today, and I'm going to do more research. r2d2 has additional connection checks, though we haven't validated the behavior for that case.

@jan-auer jan-auer merged commit 32b43a7 into master Aug 9, 2022
@jan-auer jan-auer deleted the release/fix-redis-ping branch August 9, 2022 06:46
@jan-auer jan-auer mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@beezz beezz Awaiting requested review from beezz

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @jjbayer