Private key is not longer required for DSN #232
Conversation
|
Travis has been broken for a while. Let's fix it in on a separate PR. |
docs/index.rst
Outdated
| @@ -106,7 +106,7 @@ The only thing you have to do is provide a DSN, either by registering an instanc | |||
|
|
|||
| protected override void ApplicationStartup(TinyIoCContainer container, IPipelines pipelines) | |||
| { | |||
| container.Register(new Dsn("http://public:secret@example.com/project-id")); | |||
| container.Register(new Dsn("http://[email protected]/project-id")); | |||
There was a problem hiding this comment.
nit: You could use ___PUBLIC_DSN___ here to show an interactive DSN chooser in docs and the setup wizard:
container.Register(new Dsn("___PUBLIC_DSN___"));
|
The question about dsn w/o private key. I tried to use dsn with only public key, but our sentry server doesn't accept such requests and return 403 error. Is it should be somehow configured on server side as well, or probably it's needed specific sentry version? We use 8.19.0 |
|
The private DSN is still required up to Sentry 8.22.0. The release of Sentry 9 to on-premise customers is just around the corner and will fix this. Also note that some features introduced recently, such as the improved contexts, will require an updated sentry server. |
|
ok, thanks @jan-auer |
The private DSNs (including secret keys) will be officially deprecated soon. This PR allows users to specify a public DSN and makes sure the sentry_secret is not included in the header anymore. For backwards compatibility, a private DSN can still be used, though.