Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Cake build script #189

Merged
merged 7 commits into from
Nov 6, 2017
Merged

Cake build script #189

merged 7 commits into from
Nov 6, 2017

Conversation

will14smith
Copy link
Contributor

I've been following the .NET Core conversation and moving the build system to using Cake seemed to be one of the next steps, so I've given it a go!

Things I've done:

  • Migrated the project files to use the new csproj format. This makes them simpler (useful when you want to hand write conditionals) and gives "easy" access to which allows multiple framework to be targeted. When I started the idea was this would simplify things, as to whether it did ¯\(ツ)/¯ .

  • Removed SharpRaven.WebTest. Migrating this would have been "interesting". Given that it wasn't an automated test and didn't contain any substantial code, I just removed it.

  • "Fixed" some tests. The new build scripts seems to run tests slightly differently than the old one did so I had to resolve some issues that came up. Most of it was around Mono, dynamics, and runtime method ambiguities.

  • Add the Cake script. It builds all the frameworks, runs tests on all of them, and packages them. Works on AppVeyor (Window), TravisCI (Linux via Mono). The reason it is using AppVeyor is just because I could test different configs more easily. I'm happy to modify the script to work with TeamCity but might some help testing it.

AppVeyor tests
TravisCI tests

I would have liked to have submitted a smaller PR but it's all fairly interconnected (if you would like a smaller PR then I could possibly look into splitting out the project file migration).

I'm open to feedback, suggestions, changes, etc... 😄

@samukce
Copy link
Contributor

samukce commented Sep 10, 2017

Great work!

@asbjornu
Copy link
Contributor

@will14smith: Thanks so much for this! How does this relate to the existing cake branch (that also incorporates the httpclient branch)? It's great to have AppVeyor support. I would love to ditch the TeamCity build in favour of AppVeyor, but I need administrative rights within the @getsentry organisation to create a project in AppVeyor for it, and I don't. Perhaps pinging @dcramer about it will help? 😃

I'll move forward with this PR as soon as we get AppVeyor figured out.

@asbjornu
Copy link
Contributor

asbjornu commented Nov 1, 2017

@HazAT, can you please have a look at my request above?

@asbjornu asbjornu mentioned this pull request Nov 1, 2017
@HazAT
Copy link
Member

HazAT commented Nov 1, 2017

@asbjornu I will get this rolling, stay tuned.

@jan-auer
Copy link
Member

jan-auer commented Nov 2, 2017

@asbjornu The project is created in AppVeyor now:
https://ci.appveyor.com/project/sentry/raven-csharp

@asbjornu
Copy link
Contributor

asbjornu commented Nov 3, 2017

@jan-auer: Thanks!
@will14smith: Can you please add an appveyor.yml to this PR so we can see how the build fares on AppVeyor? When we have that working, I'm going to disable the TeamCity build and merge this.

@will14smith
Copy link
Contributor Author

@asbjornu There already was one :)

I've bumped the last commit to trigger it

@asbjornu
Copy link
Contributor

asbjornu commented Nov 3, 2017

@will14smith: Awesome! AppVeyor went green, but not Travis, unfortunately. 😕

@will14smith
Copy link
Contributor Author

@asbjornu There is a bug in the latest stable release of Mono https://bugzilla.xamarin.com/show_bug.cgi?id=59364

It's fixed in the nightly builds so I've set Travis to use them for now

@asbjornu
Copy link
Contributor

asbjornu commented Nov 6, 2017

@will14smith: I see. Excellent! Thanks for this! The next step now is to add to appveyor.yml so we get artifact uploads to GitHub and publishing of pre-release and stable packages to NuGet.

@asbjornu asbjornu merged commit 217edd4 into getsentry:develop Nov 6, 2017
@webchetan
Copy link

webchetan commented Nov 17, 2017

Do we have any working package for .net core >= v1.1. I so want sentry to work for .net core projects. Any help would be great. Thank you!

@asbjornu
Copy link
Contributor

asbjornu commented Mar 2, 2018

@webchetan: No packages yet, as we need to get an AppVeor build up and running. Once we have that in place, producing a .NET Standard compatible package shouldn't be too much work.

@webchetan
Copy link

@asbjornu Thank you. Package for .NET Core 2.x would be awesome. :)

@asbjornu
Copy link
Contributor

asbjornu commented Mar 5, 2018

@webchetan: As I wrote in #125, SharpRaven version 2.2.1-unstable0054 was published to NuGet.org yesterday. Please test it and report back your status. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants