-
-
Notifications
You must be signed in to change notification settings - Fork 120
Conversation
Great work! |
@will14smith: Thanks so much for this! How does this relate to the existing I'll move forward with this PR as soon as we get AppVeyor figured out. |
@HazAT, can you please have a look at my request above? |
@asbjornu I will get this rolling, stay tuned. |
@asbjornu The project is created in AppVeyor now: |
@jan-auer: Thanks! |
@asbjornu There already was one :) I've bumped the last commit to trigger it |
@will14smith: Awesome! AppVeyor went green, but not Travis, unfortunately. 😕 |
@asbjornu There is a bug in the latest stable release of Mono https://bugzilla.xamarin.com/show_bug.cgi?id=59364 It's fixed in the nightly builds so I've set Travis to use them for now |
@will14smith: I see. Excellent! Thanks for this! The next step now is to add to |
Do we have any working package for .net core >= v1.1. I so want sentry to work for .net core projects. Any help would be great. Thank you! |
@webchetan: No packages yet, as we need to get an AppVeor build up and running. Once we have that in place, producing a .NET Standard compatible package shouldn't be too much work. |
@asbjornu Thank you. Package for .NET Core 2.x would be awesome. :) |
@webchetan: As I wrote in #125, SharpRaven version |
I've been following the .NET Core conversation and moving the build system to using Cake seemed to be one of the next steps, so I've given it a go!
Things I've done:
Migrated the project files to use the new csproj format. This makes them simpler (useful when you want to hand write conditionals) and gives "easy" access to which allows multiple framework to be targeted. When I started the idea was this would simplify things, as to whether it did ¯\(ツ)/¯ .
Removed SharpRaven.WebTest. Migrating this would have been "interesting". Given that it wasn't an automated test and didn't contain any substantial code, I just removed it.
"Fixed" some tests. The new build scripts seems to run tests slightly differently than the old one did so I had to resolve some issues that came up. Most of it was around Mono, dynamics, and runtime method ambiguities.
Add the Cake script. It builds all the frameworks, runs tests on all of them, and packages them. Works on AppVeyor (Window), TravisCI (Linux via Mono). The reason it is using AppVeyor is just because I could test different configs more easily. I'm happy to modify the script to work with TeamCity but might some help testing it.
AppVeyor tests
TravisCI tests
I would have liked to have submitted a smaller PR but it's all fairly interconnected (if you would like a smaller PR then I could possibly look into splitting out the project file migration).
I'm open to feedback, suggestions, changes, etc... 😄