Test on HttpRequestBodyConverter #148
Conversation
|
|
||
| namespace SharpRaven.UnitTests.Data | ||
| { | ||
| [TestFixture] | ||
| public class HttpRequestBodyConverterTests | ||
| { | ||
| #region TestCaseData |
There was a problem hiding this comment.
Did ReSharper add this region according to the DotSettings profile?
There was a problem hiding this comment.
No, it is a my habit, usually i wrap private code on a dedicated region. Can i remove it if you want. If you are using a code convention let me know i will happy to follow it :)
There was a problem hiding this comment.
Please remove it. I believe the associated ReSharper settings should place private classes at the bottom of the parent class, if not, let me know and I'll adjust.
| @@ -60,6 +63,52 @@ public void Convert_Form_ReturnsForm() | |||
|
|
|||
|
|
|||
| [Test] | |||
| [TestCaseSource(typeof(JsonTestCase), "TestCasesContentType")] | |||
There was a problem hiding this comment.
Wouldn't it be easier to read if you just used [TestCase()] with the content type strings directly in the attribute, instead of extracting them to a source type? I'd understand it if the source data was more complex, but since it's just a string... 😃
|
@xpicio Excellent, thanks! |
Hello, i just added more test on
HttpRequestBodyConverter. AboutMultiPartFormHttpRequestBodyConverteri do not have any particular idea about test, both Nancy and ASP.NET splitmultipart/form-datainFormandFilescollections so there is not any special test to do on it. If you have any idea about more test to add, let me know.This change is