deps: Upgrade various packages #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for newest version of typescript
|
there are some lint errors that will have to be fixed when merging in sentry |
scttcper
commented
Oct 10, 2024
| @@ -38,4 +38,4 @@ jobs: | |||
| SENTRY_ESLINT_RELAXED: 1 | |||
| run: | | |||
| cd sentry | |||
| yarn lint | |||
There was a problem hiding this comment.
biome kept running and throwing errors? we don't inherit the biome lint rules though
scttcper
commented
Oct 10, 2024
Comment on lines
+247
to
+251
| // TODO(scttcper): Turn no-empty-object-type on to make our types more strict | ||
| // '@typescript-eslint/no-empty-object-type': 'error', | ||
| // TODO(scttcper): Turn no-function on to make our types more strict | ||
| // '@typescript-eslint/no-unsafe-function-type': 'error', | ||
| '@typescript-eslint/no-wrapper-object-types': 'error', |
There was a problem hiding this comment.
ban-types is now a mix of no-restricted-types and these others that could be enabled. would be nice to ban Function type. it s the same as (...any) => any
evanpurkhiser
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for latest version of typescript