-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync product area labels with GH project containing all issues #460
Sync product area labels with GH project containing all issues #460
Conversation
… cares about project
We'll need to check to make sure the getsantry bot has appropriate permissions for GitHub projects (read and write) |
Demo looks great. Does the product area sync go the other way? If you modify the project field does the label change? What happens if you add a second product area label? Are there race conditions? |
The product area sync does not go the other way, as far as I could gather there doesn't seem to be anything for GitHub events for project. Link to GitHub events In a rerouting scenario, if a second product area label is added, the first product area label is removed. The bot will also change the project field to be the product area of the second product area label. Demo below Screen.Recording.2023-05-24.at.2.31.31.PM.mov |
Oof, that's rough. Can we reach out to GitHub in our shared Slack channel to see if there are any workarounds besides polling? It feels like this is going to be a pretty common case and we don't want to get out of sync. |
actually, looks like there is something I can work with: Going to take some time and investigate this today |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
=======================================
Coverage ? 82.52%
=======================================
Files ? 96
Lines ? 2386
Branches ? 462
=======================================
Hits ? 1969
Misses ? 411
Partials ? 6 ☔ View full report in Codecov by Sentry. |
Now done Screen.Recording.2023-05-26.at.12.22.03.PM.mov
I did notice one if I switch between Product Area fields extremely fast on the project. It might be due to the delay when applying a label to the issue once a Product Area field value is set. It requires a user to change the Product Area field between different values in ~1 second or less. I played around and couldn't find a trivial fix for it, but it does seem to be something of a lesser priority to tackle given how hard it is to replicate |
ffc8736
to
d77cb7d
Compare
e1ccac1
to
8c0f37b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
return; | ||
} | ||
|
||
const owner = payload?.organization?.login || ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming here from #524 ... I'm wondering why we default to the empty string here. I doubt an App
octokit loaded with an empty org would work. I think we should let an exception bubble up if payload.organization.login
does not exist.
This PR adds three main things:
Issues Someone Else Cares About
project when GTM, support, or outside Sentry org members create issues.Product Area: *
label is added to an issue, it will be added to theIssues Someone Else Cares About
project if it's not already there. After, theProduct Area: *
label will be synced with theProduct Area
field on the project.Product Area
field changes, the correspondingProduct Area: *
label is added to an issueDemo:
Screen.Recording.2023-05-24.at.10.53.05.AM.mov